Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1659993002: [Extensions UI Mac] Fix race condition in showing the icon surfacing bubble (Closed)

Created:
4 years, 10 months ago by Devlin
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Fix race condition in showing the icon surfacing bubble The toolbar icon surfacing bubble shows up the first time the user runs the browser with the --extension-action-redesign feature. There's a race condition in the mac code where if the browser window starts up before the extension system is ready, the code incorrectly infers that there are no new extensions, and doesn't show the bubble. Fix this, and add a test. BUG=582512 Review URL: https://codereview.chromium.org/1643963003 Cr-Commit-Position: refs/heads/master@{#372410} (cherry picked from commit 213c3cfdc605711c89dc202867241cd49badef98) Committed: https://chromium.googlesource.com/chromium/src/+/0199dfd31a1b5c637819377c7b31f98b9ea1cb62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M chrome/browser/extensions/browser_action_test_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 10 months ago (2016-02-02 19:57:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0199dfd31a1b5c637819377c7b31f98b9ea1cb62.

Powered by Google App Engine
This is Rietveld 408576698