Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1643963003: [Extensions UI Mac] Fix race condition in showing the icon surfacing bubble (Closed)

Created:
4 years, 10 months ago by Devlin
Modified:
4 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Fix race condition in showing the icon surfacing bubble The toolbar icon surfacing bubble shows up the first time the user runs the browser with the --extension-action-redesign feature. There's a race condition in the mac code where if the browser window starts up before the extension system is ready, the code incorrectly infers that there are no new extensions, and doesn't show the bubble. Fix this, and add a test. BUG=582512 Committed: https://crrev.com/213c3cfdc605711c89dc202867241cd49badef98 Cr-Commit-Position: refs/heads/master@{#372410}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M chrome/browser/extensions/browser_action_test_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Devlin
Avi, mind taking a look when you get back?
4 years, 10 months ago (2016-01-29 18:14:35 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 10 months ago (2016-01-29 20:22:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643963003/20001
4 years, 10 months ago (2016-01-29 20:37:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-01-29 20:45:10 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 20:46:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/213c3cfdc605711c89dc202867241cd49badef98
Cr-Commit-Position: refs/heads/master@{#372410}

Powered by Google App Engine
This is Rietveld 408576698