Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

Issue 1659993002: [Extensions UI Mac] Fix race condition in showing the icon surfacing bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
index 4de33c2da637480e0d84c1fb59a0768f783f4a9f..4a1de10e5e699e2f19555cf0d758debf279e198e 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
@@ -122,6 +122,10 @@ const CGFloat kMinimumContainerWidth = 3.0;
}
}
+- (BOOL)trackingEnabled {
+ return trackingArea_.get() != nullptr;
+}
+
- (void)keyDown:(NSEvent*)theEvent {
// If this is the overflow container, we handle three key events: left, right,
// and space. Left and right navigate the actions within the container, and
@@ -175,6 +179,10 @@ const CGFloat kMinimumContainerWidth = 3.0;
}
}
+- (BOOL)isHighlighting {
+ return highlight_.get() != nullptr;
+}
+
- (void)setIsOverflow:(BOOL)isOverflow {
if (isOverflow_ != isOverflow) {
isOverflow_ = isOverflow;

Powered by Google App Engine
This is Rietveld 408576698