chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm - Issue 1659993002: [Extensions UI Mac] Fix race condition in showing the icon surfacing bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

Issue 1659993002: [Extensions UI Mac] Fix race condition in showing the icon surfacing bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/browser_action_test_util.h ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

index cde8d81b265b377cbfe764c4613f00fbcce7d3d8..e743d0c18124b8b18810998ce742441f514424e7 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

@@ -193,6 +193,12 @@ void BrowserActionTestUtil::SetWidth(int width) {

[containerView setFrame:frame];

}

+bool BrowserActionTestUtil::IsHighlightingForSurfacingBubble() {

+ BrowserActionsContainerView* containerView =

+ [GetController(browser_, test_helper_.get()) containerView];

+ return [containerView trackingEnabled] && [containerView isHighlighting];

ToolbarActionsBar* BrowserActionTestUtil::GetToolbarActionsBar() {

return [GetController(browser_, test_helper_.get()) toolbarActionsBar];

}