Remove custom counts histogram from the blink API.

Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
Committed: https://crrev.com/530e197ee183cc20df98f325e19c21848b8d3da4
Cr-Commit-Position: refs/heads/master@{#373827}

[dtapuska, 2016-02-02 14:45:37]

Description was changed from

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
==========

to

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
==========

[dtapuska, 2016-02-02 14:45:37]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org, esprehn@chromium.org, haraken@chromium.org,
nhiroki@chromium.org

[dtapuska, 2016-02-02 14:46:43]

PTAL; I hope that I have used
DEFINE_STATIC_LOCAL and
DEFINE_THREAD_SAFE_STATIC_LOCAL in the correct places.

When I couldn't fully understand if the class was only executed from a single
thread I used the thread safe version to be cautious. Owners please check this
carefully.

[haraken, 2016-02-03 15:29:23]

WebKit/Source/ LGTM.

I'm not 100% sure if you're using DEFINE_THREAD_SAFE_STATIC_LOCAL correctly, but
if you use DEFINE_STATIC_LOCAL in a thread-unsafe place, you'll hit the assert
in DEFINE_STATIC_LOCAL. So I'm fine with landing this CL trusting the assert.

[Charlie Reis, 2016-02-03 18:33:11]

content/ LGTM.

[dtapuska, 2016-02-04 22:50:04]

On 2016/02/03 18:33:11, Charlie Reis wrote:
> content/ LGTM.

esprehn@; anything to add?

[esprehn, 2016-02-04 23:25:23]

lgtm, some of the THREAD_SAFE ones don't need to be though.

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp (right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:139:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, clearForCloseHistogram,
new CustomCountHistogram("WebCore.ScriptController.clearForClose", 0, 10000,
50));
this doesn't need to be thread safe, ScriptController is main thread only.

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:417:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, clearWindowProxyHistogram,
new CustomCountHistogram("WebCore.ScriptController.clearWindowProxy", 0, 10000,
50));
ditto

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/FontFaceSet.cpp (right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceSet.cpp:483:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, webFontsInPageHistogram,
new CustomCountHistogram("WebFont.WebFontsInPage", 1, 100, 50));
FontFaceSet is main thread only today, someday it might need to be thread safe,
but it isn't in general today.

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:223:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram,
blankTextShownTimeHistogram, new
CustomCountHistogram("WebFont.BlankTextShownTime", 0, 10000, 50));
Pretty sure this is also main thread only

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:257:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, under10kHistogram, new
CustomCountHistogram("WebFont.DownloadTime.0.Under10KB", 0, 10000, 50));
ditto to all of these

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
(right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp:80:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, preloadDelayHistogram, new
CustomCountHistogram("WebCore.PreloadDelayMs", 0, 2000, 20));
main thread only, m_document below is only accessible from the main thread

[nhiroki, 2016-02-05 00:55:41]

Source/web/WebEmbeddedWorkerImpl.cpp
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

LGTM

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
(right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:97:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, scriptCountHistogram, new
CustomCountHistogram("ServiceWorker.ScriptCount", 1, 1000, 50));
_THREAD_SAFE_ should be correct. This function can be called on multiple worker
threads.

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/1659053002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp:317:
DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, scriptSizeHistogram, new
CustomCountHistogram("ServiceWorker.ScriptSize", 1000, 5000000, 50));
This function is called only on the main thread (a worker thread will start at
line 324), so _THREAD_SAFE_ is not necessary.

[dtapuska, 2016-02-05 15:03:51]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-02-05 15:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, creis@chromium.org, esprehn@chromium.org,
nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1659053002/#ps20001
(title: "Fix a few thread_safe_static_local -> static_local as per feedback in
reviews")

[commit-bot: I haz the power, 2016-02-05 15:04:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659053002/20001

[commit-bot: I haz the power, 2016-02-05 16:38:52]

Description was changed from

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
==========

to

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
==========

[commit-bot: I haz the power, 2016-02-05 16:38:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-05 16:40:07]

Description was changed from

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012
==========

to

==========
Remove custom counts histogram from the blink API.

Convert histogramCustomCount Platform API calls into the new API
for histograms. This provides cached histogram recording which
is slightly faster.

BUG=583012

Committed: https://crrev.com/530e197ee183cc20df98f325e19c21848b8d3da4
Cr-Commit-Position: refs/heads/master@{#373827}
==========

[commit-bot: I haz the power, 2016-02-05 16:40:08]

Patchset 2 (id:??) landed as
https://crrev.com/530e197ee183cc20df98f325e19c21848b8d3da4
Cr-Commit-Position: refs/heads/master@{#373827}