third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 1659053002: Remove custom counts histogram from the blink API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 1659053002: Remove custom counts histogram from the blink API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few thread_safe_static_local -> static_local as per feedback in reviews Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp ('k') | third_party/WebKit/Source/platform/fonts/FontCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 4aa783b33ee42bb4d96b033cce0537fcb5c54adf..8fdb935c43cc41dc37c59eedf778f1aa1546ec21 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -55,6 +55,7 @@

#include "modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h"

#include "modules/serviceworkers/ServiceWorkerThread.h"

#include "modules/serviceworkers/WaitUntilObserver.h"

+#include "platform/Histogram.h"

#include "platform/network/ResourceRequest.h"

#include "platform/weborigin/DatabaseIdentifier.h"

#include "platform/weborigin/KURL.h"

@@ -93,11 +94,13 @@ ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope()

void ServiceWorkerGlobalScope::didEvaluateWorkerScript()

{

- if (Platform* platform = Platform::current()) {

- platform->histogramCustomCounts("ServiceWorker.ScriptCount", m_scriptCount, 1, 1000, 50);

- platform->histogramCustomCounts("ServiceWorker.ScriptTotalSize", m_scriptTotalSize, 1000, 5000000, 50);

- if (m_scriptCachedMetadataTotalSize)

- platform->histogramCustomCounts("ServiceWorker.ScriptCachedMetadataTotalSize", m_scriptCachedMetadataTotalSize, 1000, 50000000, 50);

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, scriptCountHistogram, new CustomCountHistogram("ServiceWorker.ScriptCount", 1, 1000, 50));

+ scriptCountHistogram.count(m_scriptCount);

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, scriptTotalSizeHistogram, new CustomCountHistogram("ServiceWorker.ScriptTotalSize", 1000, 5000000, 50));

+ scriptTotalSizeHistogram.count(m_scriptTotalSize);

+ if (m_scriptCachedMetadataTotalSize) {

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, cachedMetadataHistogram, new CustomCountHistogram("ServiceWorker.ScriptCachedMetadataTotalSize", 1000, 50000000, 50));

+ cachedMetadataHistogram.count(m_scriptCachedMetadataTotalSize);

}

m_didEvaluateScript = true;

}