third_party/WebKit/Source/platform/fonts/FontCache.cpp - Issue 1659053002: Remove custom counts histogram from the blink API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCache.cpp

Issue 1659053002: Remove custom counts histogram from the blink API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few thread_safe_static_local -> static_local as per feedback in reviews Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontCache.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontCache.cpp b/third_party/WebKit/Source/platform/fonts/FontCache.cpp

index a9cf27c8c50d1e2b94553347070e567db26bea86..649e475b77286cadc795edc066c661081bacfdd4 100644

--- a/third_party/WebKit/Source/platform/fonts/FontCache.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontCache.cpp

@@ -31,6 +31,7 @@

#include "platform/FontFamilyNames.h"

+#include "platform/Histogram.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/fonts/AlternateFontFamily.h"

#include "platform/fonts/FontCacheClient.h"

@@ -285,7 +286,8 @@ static inline void purgeFallbackListShaperCache()

}

gFallbackListShaperCache->clear();

}

- Platform::current()->histogramCustomCounts("Blink.Fonts.ShapeCache", items, 1, 1000000, 50);

+ DEFINE_STATIC_LOCAL(CustomCountHistogram, shapeCacheHistogram, ("Blink.Fonts.ShapeCache", 1, 1000000, 50));

+ shapeCacheHistogram.count(items);

}

void FontCache::invalidateShapeCache()