third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp - Issue 1659053002: Remove custom counts histogram from the blink API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

Issue 1659053002: Remove custom counts histogram from the blink API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few thread_safe_static_local -> static_local as per feedback in reviews Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

index 21dd240687287dee489a0f041a75014aab28b58e..1df2916da0984189c86d6a82de15d37b93546172 100644

--- a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

@@ -8,6 +8,7 @@

#include "core/dom/IdleRequestCallback.h"

#include "core/dom/IdleRequestOptions.h"

#include "core/inspector/InspectorTraceEvents.h"

+#include "platform/Histogram.h"

#include "platform/Logging.h"

#include "platform/TraceEvent.h"

#include "public/platform/Platform.h"

@@ -121,14 +122,18 @@ void ScriptedIdleTaskController::runCallback(CallbackId id, double deadlineSecon

return;

double allottedTimeMillis = std::max((deadlineSeconds - monotonicallyIncreasingTime()) * 1000, 0.0);

- Platform::current()->histogramCustomCounts("WebCore.ScriptedIdleTaskController.IdleCallbackDeadline", allottedTimeMillis, 0, 50, 50);

+ DEFINE_STATIC_LOCAL(CustomCountHistogram, idleCallbackDeadlineHistogram, ("WebCore.ScriptedIdleTaskController.IdleCallbackDeadline", 0, 50, 50));

+ idleCallbackDeadlineHistogram.count(allottedTimeMillis);

TRACE_EVENT1("devtools.timeline", "FireIdleCallback",

"data", InspectorIdleCallbackFireEvent::data(executionContext(), id, allottedTimeMillis, callbackType == IdleDeadline::CallbackType::CalledByTimeout));

callback->handleEvent(IdleDeadline::create(deadlineSeconds, callbackType));

double overrunMillis = std::max((monotonicallyIncreasingTime() - deadlineSeconds) * 1000, 0.0);

- Platform::current()->histogramCustomCounts("WebCore.ScriptedIdleTaskController.IdleCallbackOverrun", overrunMillis, 0, 10000, 50);

+ DEFINE_STATIC_LOCAL(CustomCountHistogram, idleCallbackOverrunHistogram, ("WebCore.ScriptedIdleTaskController.IdleCallbackOverrun", 0, 10000, 50));

+ idleCallbackOverrunHistogram.count(overrunMillis);

}

void ScriptedIdleTaskController::stop()