Fixes the interactive default browser UX for policy setting

Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
Committed: https://crrev.com/8db6a8be4aaf1b158a6e7b10b4991d91ac69fa67
Cr-Commit-Position: refs/heads/master@{#374831}

[Patrick Monette, 2016-02-02 16:38:31]

Description was changed from

==========
Fixes the interative default browser UX for policy setting

Also removes IsOwnedByWorker() and IsInteractiveSetDefaultPermitted()
and replaced them with member variables because those were unnecessarily
virtual.

BUG=583317
==========

to

==========
Fixes the interative default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

[Patrick Monette, 2016-02-02 16:44:04]

pmonette@chromium.org changed reviewers:
+ grt@chromium.org

[Patrick Monette, 2016-02-02 16:44:04]

PTAL

[Patrick Monette, 2016-02-02 16:44:17]

Description was changed from

==========
Fixes the interative default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

to

==========
Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

[grt (UTC plus 2), 2016-02-02 17:28:22]

Looks fine overall, although the pair of bools at each callsite is a bit hard to
understand at first glance. What do you think about keeping the ownership bool
as an arg to the ctor, but making the interactive_permitted bool settable on the
Worker via a function call (with the default being whatever the common case
happens to be)?

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/browser_proc...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/browser_proc...
chrome/browser/browser_process_impl.cc:1199: new
ShellIntegration::DefaultBrowserWorker(NULL, false, false);
nit: NULL -> nullptr while you're here

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration.cc (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration.cc:192: if (observer_) {
nit: omit braces

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration.h:214:
DefaultWebClientWorker(DefaultWebClientObserver* observer,
please add a doc comment for this function (and the derived classes) that
explains the new args.

[Patrick Monette, 2016-02-02 22:24:15]

Take another look!

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/browser_proc...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/browser_proc...
chrome/browser/browser_process_impl.cc:1199: new
ShellIntegration::DefaultBrowserWorker(NULL, false, false);
On 2016/02/02 17:28:22, grt wrote:
> nit: NULL -> nullptr while you're here

Done.

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration.cc (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration.cc:192: if (observer_) {
On 2016/02/02 17:28:22, grt wrote:
> nit: omit braces

Done.

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration.h:214:
DefaultWebClientWorker(DefaultWebClientObserver* observer,
On 2016/02/02 17:28:22, grt wrote:
> please add a doc comment for this function (and the derived classes) that
> explains the new args.

Done.

[grt (UTC plus 2), 2016-02-03 15:39:57]

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/external...
File chrome/browser/external_protocol/external_protocol_handler.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/external...
chrome/browser/external_protocol/external_protocol_handler.cc:41: // behavior;
if a delegate is provided it will be used instead.
please add something like:
// Ownership of |observer| is passed to the new worker.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.cc:168: interactive_permitted_(true) {}
nit: remove this from the initializer list since it's initialized in the class
definition.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:210: //  (on Linux) are involved and this can
be slow.
please add something like:
"By default, the worker will present the user with an interactive flow if
required by the platform. This can be suppressed via
|set_interactive_permitted|, in which case an attempt to set Chrome as the
default handler will silently fail on such platforms."

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:223: void SetInteractivePermitted(bool
interactive_permitted);
nit: this can be inlined as set_interactive_permitted as per
http://www.chromium.org/developers/coding-style#TOC-Inline-functions

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/ui/apps/...
File chrome/browser/ui/apps/chrome_app_delegate.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/ui/apps/...
chrome/browser/ui/apps/chrome_app_delegate.cc:161: // Object lifetime notes: The
OpenURLFromTabBasedOnBrowserDefault is owned
should this have:
    check_if_default_browser_worker->set_interactive_permitted(false);

[Patrick Monette, 2016-02-03 23:01:38]

pmonette@chromium.org changed reviewers:
+ jam@chromium.org

[Patrick Monette, 2016-02-03 23:01:39]

I addressed your comments grt.

jam@ I need review from a owner. PTAL

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/external...
File chrome/browser/external_protocol/external_protocol_handler.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/external...
chrome/browser/external_protocol/external_protocol_handler.cc:41: // behavior;
if a delegate is provided it will be used instead.
On 2016/02/03 15:39:56, grt wrote:
> please add something like:
> // Ownership of |observer| is passed to the new worker.

Done.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.cc:168: interactive_permitted_(true) {}
On 2016/02/03 15:39:56, grt wrote:
> nit: remove this from the initializer list since it's initialized in the class
> definition.

Done.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:210: //  (on Linux) are involved and this can
be slow.
On 2016/02/03 15:39:56, grt wrote:
> please add something like:
> "By default, the worker will present the user with an interactive flow if
> required by the platform. This can be suppressed via
> |set_interactive_permitted|, in which case an attempt to set Chrome as the
> default handler will silently fail on such platforms."

Done.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:223: void SetInteractivePermitted(bool
interactive_permitted);
On 2016/02/03 15:39:56, grt wrote:
> nit: this can be inlined as set_interactive_permitted as per
> http://www.chromium.org/developers/coding-style#TOC-Inline-functions

Done.

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/ui/apps/...
File chrome/browser/ui/apps/chrome_app_delegate.cc (right):

https://codereview.chromium.org/1657933003/diff/20001/chrome/browser/ui/apps/...
chrome/browser/ui/apps/chrome_app_delegate.cc:161: // Object lifetime notes: The
OpenURLFromTabBasedOnBrowserDefault is owned
On 2016/02/03 15:39:56, grt wrote:
> should this have:
>     check_if_default_browser_worker->set_interactive_permitted(false);

The worker here is only used to check the default state. That's why it's not
there.

[grt (UTC plus 2), 2016-02-04 15:54:26]

lgtm

[jam, 2016-02-04 19:28:08]

On 2016/02/03 23:01:39, Patrick Monette wrote:
> I addressed your comments grt.
> 
> jam@ I need review from a owner. PTAL

please pick as specific owner as possible. i.e. use src/chrome/owners before
src/owners

[Patrick Monette, 2016-02-08 22:30:53]

pmonette@chromium.org changed reviewers:
- jam@chromium.org

[Patrick Monette, 2016-02-08 23:37:15]

pmonette@chromium.org changed reviewers:
+ pkasting@chromium.org, thakis@chromium.org

[Patrick Monette, 2016-02-08 23:37:15]

thakis@ Please review everything under chrome/browser/* excluding the /ui
folder.

pkasting@ Can you review chrome/browser/ui please.

Thanks!

[Peter Kasting, 2016-02-09 00:59:53]

LGTM

[Nico, 2016-02-09 03:01:32]

is it possible to write a test for this?

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/custom_h...
File chrome/browser/custom_handlers/protocol_handler_registry.cc (right):

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/custom_h...
chrome/browser/custom_handlers/protocol_handler_registry.cc:298: true);
I'd discourage boolean parameters as they make it impossible to know what "true"
means here. Consider making this an enum instead, then this line is much less
mysterious. (or do `bool named_thing = true;` then pass named_thing, or do
`/*named_thing=*/true`)

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:220: // freed in the destructor.
I find "optionally owned" code is usually hard to reason about. is it not
possible to have clear ownership semantics here? can this cass own observer
either always (in that case, pass a scoped_ptr/unique_ptr) or never?

[Peter Kasting, 2016-02-09 06:04:23]

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:220: // freed in the destructor.
On 2016/02/09 03:01:31, Nico wrote:
> I find "optionally owned" code is usually hard to reason about. is it not
> possible to have clear ownership semantics here? can this cass own observer
> either always (in that case, pass a scoped_ptr/unique_ptr) or never?

I agree.

In the limit, two constructors (raw pointer and scoped_ptr) would be better than
a raw pointer + "take ownership" bool.  But a consistent model would be even
better.

Either one will also avoid Nico's complaint about bool args.

[Patrick Monette, 2016-02-09 17:15:05]

thakis@ browser_process_impl is has no real tests. I've added a comment to
justify the use of set_interactive_permitted(). Do you think it is sufficient?

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/custom_h...
File chrome/browser/custom_handlers/protocol_handler_registry.cc (right):

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/custom_h...
chrome/browser/custom_handlers/protocol_handler_registry.cc:298: true);
On 2016/02/09 03:01:31, Nico wrote:
> I'd discourage boolean parameters as they make it impossible to know what
"true"
> means here. Consider making this an enum instead, then this line is much less
> mysterious. (or do `bool named_thing = true;` then pass named_thing, or do
> `/*named_thing=*/true`)

Done.

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1657933003/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:220: // freed in the destructor.
On 2016/02/09 06:04:22, Peter Kasting wrote:
> On 2016/02/09 03:01:31, Nico wrote:
> > I find "optionally owned" code is usually hard to reason about. is it not
> > possible to have clear ownership semantics here? can this cass own observer
> > either always (in that case, pass a scoped_ptr/unique_ptr) or never?
> 
> I agree.
> 
> In the limit, two constructors (raw pointer and scoped_ptr) would be better
than
> a raw pointer + "take ownership" bool.  But a consistent model would be even
> better.
> 
> Either one will also avoid Nico's complaint about bool args.

Yeah I also agree and I'm working on fixing this is another CL to limit the size
of the code reviews.
It will change the observer to a single callback owned by the
DefaultWebClientWorker class that can be invalidated via weak_ptrs.

[Patrick Monette, 2016-02-09 17:16:30]

Patchset #4 (id:60001) has been deleted

[Patrick Monette, 2016-02-09 23:54:15]

thakis@ Friendly ping

[Patrick Monette, 2016-02-10 17:26:42]

https://codereview.chromium.org/1657933003/diff/100001/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/1657933003/diff/100001/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:1199: bool delete_observer =
Woops this isn't compiling. Fixed with the rebase.

[Nico, 2016-02-10 17:33:58]

lgtm, looking forward to the change that makes ownership cleaner.

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:1202: /*delete_observer=*/false);
add a comment where the deletino happens

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/star...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/star...
chrome/browser/ui/startup/default_browser_prompt.cc:181:
/*delete_observer=*/false))
ditto

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/browser_options_handler.cc:190: this,
/*delete_observer=*/false);
ditto

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:133:
/*delete_observer=*/false)),
ditto

[Patrick Monette, 2016-02-10 20:44:42]

Thank you!

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:1202: /*delete_observer=*/false);
On 2016/02/10 17:33:58, Nico wrote:
> add a comment where the deletino happens

Done.

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/star...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/star...
chrome/browser/ui/startup/default_browser_prompt.cc:181:
/*delete_observer=*/false))
On 2016/02/10 17:33:58, Nico wrote:
> ditto

Done.

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/browser_options_handler.cc:190: this,
/*delete_observer=*/false);
On 2016/02/10 17:33:58, Nico wrote:
> ditto

Done.

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right):

https://codereview.chromium.org/1657933003/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:133:
/*delete_observer=*/false)),
On 2016/02/10 17:33:58, Nico wrote:
> ditto

Done.

[Patrick Monette, 2016-02-10 20:44:46]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-02-10 20:44:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, grt@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1657933003/#ps140001
(title: "Comments")

[commit-bot: I haz the power, 2016-02-10 20:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657933003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657933003/140001

[commit-bot: I haz the power, 2016-02-10 21:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 21:08:47]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Patrick Monette, 2016-02-10 22:07:36]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-02-10 22:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
pkasting@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1657933003/#ps160001
(title: "Fix unittests")

[commit-bot: I haz the power, 2016-02-10 22:10:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657933003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657933003/160001

[commit-bot: I haz the power, 2016-02-10 22:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 22:17:43]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Patrick Monette, 2016-02-11 00:32:39]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-02-11 00:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
pkasting@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1657933003/#ps180001
(title: "Fix merge issue")

[commit-bot: I haz the power, 2016-02-11 00:36:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657933003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657933003/180001

[commit-bot: I haz the power, 2016-02-11 01:50:46]

Description was changed from

==========
Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

to

==========
Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

[commit-bot: I haz the power, 2016-02-11 01:50:47]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-02-16 22:33:55]

Description was changed from

==========
Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317
==========

to

==========
Fixes the interactive default browser UX for policy setting

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317

Committed: https://crrev.com/8db6a8be4aaf1b158a6e7b10b4991d91ac69fa67
Cr-Commit-Position: refs/heads/master@{#374831}
==========

[commit-bot: I haz the power, 2016-02-16 22:33:56]

Patchset 9 (id:??) landed as
https://crrev.com/8db6a8be4aaf1b158a6e7b10b4991d91ac69fa67
Cr-Commit-Position: refs/heads/master@{#374831}