Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1657933003: Fixes the interactive default browser UX for policy setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge issue Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_protocol/external_protocol_handler.cc ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc
diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
index c7176520087901fabebd3f485afd1140b72b786b..b631125ae986d2877644bb1f4a1674c7d8e535a4 100644
--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
@@ -17,7 +17,10 @@ class FakeExternalProtocolHandlerWorker
shell_integration::DefaultWebClientObserver* observer,
const std::string& protocol,
shell_integration::DefaultWebClientState os_state)
- : shell_integration::DefaultProtocolClientWorker(observer, protocol),
+ : shell_integration::DefaultProtocolClientWorker(
+ observer,
+ protocol,
+ /*delete_observer=*/true),
os_state_(os_state) {}
private:
@@ -30,7 +33,7 @@ class FakeExternalProtocolHandlerWorker
this, os_state_));
}
- void SetAsDefault(bool interactive_permitted) override {
+ void SetAsDefault() override {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(
« no previous file with comments | « chrome/browser/external_protocol/external_protocol_handler.cc ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698