chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc - Issue 1657933003: Fixes the interactive default browser UX for policy setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 1657933003: Fixes the interactive default browser UX for policy setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix merge issue Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry.cc ('k') | chrome/browser/external_protocol/external_protocol_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

index 094659952fbaf0019f96101fdd31f91e2a2ee216..2ddfae0bedddfa5fafb0bdb00291efc012e79b47 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

@@ -224,7 +224,10 @@ class FakeProtocolClientWorker

shell_integration::DefaultWebClientObserver* observer,

const std::string& protocol,

bool force_failure)

- : shell_integration::DefaultProtocolClientWorker(observer, protocol),

+ : shell_integration::DefaultProtocolClientWorker(

+ observer,

+ protocol,

+ /*delete_observer*/ true),

force_failure_(force_failure) {}

private:

@@ -242,7 +245,7 @@ class FakeProtocolClientWorker

state));

}

- void SetAsDefault(bool interactive_permitted) override {

+ void SetAsDefault() override {

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&FakeProtocolClientWorker::OnSetAsDefaultAttemptComplete,