Fixes the interactive default browser UX for policy setting

chrome/browser/ui/apps/chrome_app_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/apps/chrome_app_delegate.h"
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 92 matching lines @@
       case ShellIntegration::STATE_IS_DEFAULT:
         OpenURLFromTabInternal(profile, params_);
         break;
       case ShellIntegration::STATE_NOT_DEFAULT:
       case ShellIntegration::STATE_UNKNOWN:
         platform_util::OpenExternal(profile, params_.url);
         break;
     }
   }
 
-  bool IsOwnedByWorker() override { return true; }
-
  private:
   scoped_ptr<content::WebContents> source_;
   const content::OpenURLParams params_;
 };
 
 }  // namespace
 
 // static
 void ChromeAppDelegate::RelinquishKeepAliveAfterTimeout(
     const base::WeakPtr<ChromeAppDelegate>& chrome_app_delegate) {
@@ skipping 26 matching lines @@
     // This NewWindowContentsDelegate was given ownership of the incoming
     // WebContents by being assigned as its delegate within
     // ChromeAppDelegate::AddNewContents, but this is the first time
     // NewWindowContentsDelegate actually sees the WebContents.
     // Here it is captured for deletion.
     scoped_ptr<content::WebContents> owned_source(source);
     scoped_refptr<ShellIntegration::DefaultWebClientWorker>
         check_if_default_browser_worker =
             new ShellIntegration::DefaultBrowserWorker(
                 new OpenURLFromTabBasedOnBrowserDefault(std::move(owned_source),
-                                                        params));
+                                                        params),
+                true);
     // Object lifetime notes: The OpenURLFromTabBasedOnBrowserDefault is owned

[grt (UTC plus 2), 2016/02/03 15:39:56]

should this have:
    check_if_default_browser_worker->set_interactive_permitted(false);

[Patrick Monette, 2016/02/03 23:01:39]

The worker here is only used to check the default state. That's why it's not
there.

     // by check_if_default_browser_worker. StartCheckIsDefault() takes lifetime
     // ownership of check_if_default_browser_worker and will clean up after
     // the asynchronous tasks.
     check_if_default_browser_worker->StartCheckIsDefault();
   }
   return NULL;
 }
 
 ChromeAppDelegate::ChromeAppDelegate(scoped_ptr<ScopedKeepAlive> keep_alive)
     : has_been_shown_(false),
@@ skipping 181 matching lines @@
                                 const content::NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_APP_TERMINATING:
       if (!terminating_callback_.is_null())
         terminating_callback_.Run();
       break;
     default:
       NOTREACHED() << "Received unexpected notification";
   }
 }