[Telemetry] Factor out common logic between inspector backend lists.

[Telemetry] Factor out common logic between inspector backend lists.

* Added base InspectorBackendList as a single point for updating contexts and
  keeping track of various InspectorBackends.
* Tabs, Extensions and OOBE now either are InspectorBackendLists or have
  InspectorBackendLists.

This fixes some extension unittests on CrOS.

BUG=345875, 233001
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253128

[tonyg, 2014-02-22 21:50:00]

I didn't get this quite as far as I wanted to, but the sweater just kept
unravelling and this seemed like a good stopping point.

[achuithb, 2014-02-24 19:24:09]

Could we flesh out the description some more? It'll be good for the git/svn log
in the future since the change is complex and large (and it also makes this
easier to review). Things like:
* Added base class InspectorBackendList as a single point for updating contexts,
and keeping track of various inspector backends.
etc.

In my first pass, this looks pretty good!

https://codereview.chromium.org/165693006/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py
(right):

https://codereview.chromium.org/165693006/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:89: #
TODO(tonyg): TabListBackend should ask InspectorBackend to
Let's add bug-id 233001 here?

[tonyg, 2014-02-24 20:39:45]

On 2014/02/24 19:24:09, achuith.bhandarkar wrote:
> Could we flesh out the description some more?

Done.

> Let's add bug-id 233001 here?

Done.

[achuithb, 2014-02-24 22:45:59]

On 2014/02/24 20:39:45, tonyg wrote:
> On 2014/02/24 19:24:09, achuith.bhandarkar wrote:
> > Could we flesh out the description some more?
> 
> Done.

Did you use git commit --amend? Unfortunately you have to manually edit (or
copy/paste) the description in Rietveld.

> > Let's add bug-id 233001 here?
> 
> Done.

[tonyg, 2014-02-24 23:09:07]

On 2014/02/24 22:45:59, achuith.bhandarkar wrote:
> On 2014/02/24 20:39:45, tonyg wrote:
> > On 2014/02/24 19:24:09, achuith.bhandarkar wrote:
> > > Could we flesh out the description some more?
> > 
> > Done.
> 
> Did you use git commit --amend? Unfortunately you have to manually edit (or
> copy/paste) the description in Rietveld.

Oops, that's exactly what I did. Fixed.

[achuithb, 2014-02-25 01:42:09]

lgtm.

https://codereview.chromium.org/165693006/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py
(right):

https://codereview.chromium.org/165693006/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py:24: # A
wrapper class for InspectorBackends.
This comment seems insufficient

https://codereview.chromium.org/165693006/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py:31:
"""Override this method to control which contexts are included."""
Is it obvious that the second argument is a context?

[tonyg, 2014-02-25 02:06:54]

Comments addressed. Thanks :)

[tonyg, 2014-02-25 02:07:21]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-02-25 02:15:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/165693006/100001

[commit-bot: I haz the power, 2014-02-25 07:39:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/165693006/100001

[commit-bot: I haz the power, 2014-02-25 09:13:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/165693006/100001

[commit-bot: I haz the power, 2014-02-25 09:32:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/165693006/100001

[commit-bot: I haz the power, 2014-02-25 09:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 09:43:14]

Try jobs failed on following builders: mac_chromium_rel

[achuithb, 2014-02-25 09:52:35]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-02-25 09:54:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/165693006/100001

[commit-bot: I haz the power, 2014-02-25 10:31:38]

Change committed as 253128

[nduca, 2014-02-26 05:33:24]

maybe causing failures due to tab ids sometimes being strings?

http://build.chromium.org/p/chromium.perf/builders/Android%20GN%20Perf/builds...

http://build.chromium.org/p/chromium.perf/builders/Android%20GN%20Perf/builds...

[achuithb, 2014-02-26 07:44:31]

On 2014/02/26 05:33:24, nduca wrote:
> maybe causing failures due to tab ids sometimes being strings?
> 
>
http://build.chromium.org/p/chromium.perf/builders/Android%2520GN%2520Perf/bu...
> 
>
http://build.chromium.org/p/chromium.perf/builders/Android%2520GN%2520Perf/bu...

Filed a bug: crbug.com/347054