tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 165693006: [Telemetry] Factor out common logic between inspector backend lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 165693006: [Telemetry] Factor out common logic between inspector backend lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/extension_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index 0923888873c5828c98b2c9f828e4ca87ffcc49db..48daeb367356547392fdf4d01c14fd2e6609efce 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -356,8 +356,8 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

"""Closes the startup window, which is an extension on official builds,

and a webpage on chromiumos"""

startup_window_ext_id = 'honijodknafkokifofgiaalefdiedpko'

- return (self.extension_dict_backend[startup_window_ext_id]

- if startup_window_ext_id in self.extension_dict_backend

+ return (self.extension_backend[startup_window_ext_id]

+ if startup_window_ext_id in self.extension_backend

else self.tab_list_backend.Get(0, None))

def _WaitForSigninScreen(self):