Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 165693006: [Telemetry] Factor out common logic between inspector backend lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/browser.py
diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py
index 3b477e5b88aa3dc29b6245a835c4c68aefedec8b..996594c6f7f97fa6532581b1a81715485a43e136 100644
--- a/tools/telemetry/telemetry/core/browser.py
+++ b/tools/telemetry/telemetry/core/browser.py
@@ -36,12 +36,6 @@ class Browser(object):
self._platform_backend = platform_backend
self._active_profilers = []
self._profilers_states = {}
-
- self._extensions = None
- if backend.supports_extensions:
- self._extensions = extension_dict.ExtensionDict(
- backend.extension_dict_backend)
-
self._local_server_controller = local_server.LocalServerController(backend)
self._tabs = tab_list.TabList(backend.tab_list_backend)
self.credentials = browser_credentials.BrowserCredentials()
@@ -97,12 +91,12 @@ class Browser(object):
raise Exception("No foreground tab found")
@property
+ @decorators.Cache
def extensions(self):
- """Returns the extension dictionary if it exists."""
if not self.supports_extensions:
raise browser_backend.ExtensionsNotSupportedException(
'Extensions not supported')
- return self._extensions
+ return extension_dict.ExtensionDict(self._browser_backend.extension_backend)
@property
def supports_tracing(self):

Powered by Google App Engine
This is Rietveld 408576698