Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/telemetry/telemetry/core/extension_page.py

Issue 165693006: [Telemetry] Factor out common logic between inspector backend lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/extension_page.py
diff --git a/tools/telemetry/telemetry/core/extension_page.py b/tools/telemetry/telemetry/core/extension_page.py
index d6c4087fa5e065580e1015a949ed1f68282d4557..3423e682a392232fc4239647f83bbd52ef6557f3 100644
--- a/tools/telemetry/telemetry/core/extension_page.py
+++ b/tools/telemetry/telemetry/core/extension_page.py
@@ -2,16 +2,22 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import re
+
from telemetry.core import web_contents
+def UrlToExtensionId(url):
+ return re.match(r"(chrome-extension://)([^/]+)", url).group(2)
+
+
class ExtensionPage(web_contents.WebContents):
"""Represents an extension page in the browser"""
- def __init__(self, extension_id, url, inspector_backend):
+
+ def __init__(self, inspector_backend):
super(ExtensionPage, self).__init__(inspector_backend)
- self.extension_id = extension_id
- self.url = url
- assert url.startswith('chrome-extension://' + extension_id)
+ self.url = inspector_backend.url
+ self.extension_id = UrlToExtensionId(self.url)
def Reload(self):
"""Reloading an extension page is used as a workaround for an extension
« no previous file with comments | « tools/telemetry/telemetry/core/extension_dict.py ('k') | tools/telemetry/telemetry/core/extension_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698