Removing more implicit LayoutUnit construction

Removing more implicit LayoutUnit construction

If you asked Canadian Prime Minister Justin Trudeau why we're removing
all implicit LayoutUnit constructors, he'd probably have an easy answer
for you: "It's 2016!"

No functional changes beyond tiny differences in conversions, most to
avoid unncecessary conversions.

BUG=581254
Committed: https://crrev.com/f4da8ea9338b87e2eba6f676c85cd2884417af62
Cr-Commit-Position: refs/heads/master@{#372856}

[leviw_travelin_and_unemployed, 2016-02-01 06:30:17]

leviw@chromium.org changed reviewers:
+ eae@chromium.org

[leviw_travelin_and_unemployed, 2016-02-01 06:30:17]

It's 2016!

[eae, 2016-02-01 06:42:37]

LGTM

It is?!? Where's my flying car?

https://codereview.chromium.org/1656743002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutInline.h (right):

https://codereview.chromium.org/1656743002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutInline.h:260: // TODO(leviw): This
should probably be an int. We don't snap equivalent lines to different heights.
We eventually want to move to fractional support for line height.

[eae, 2016-02-01 06:42:49]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-02-01 06:43:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656743002/20001

[leviw_travelin_and_unemployed, 2016-02-01 06:46:00]

On 2016/02/01 at 06:42:37, eae wrote:
> LGTM
> 
> It is?!? Where's my flying car?
> 
>
https://codereview.chromium.org/1656743002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutInline.h (right):
> 
>
https://codereview.chromium.org/1656743002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutInline.h:260: // TODO(leviw): This
should probably be an int. We don't snap equivalent lines to different heights.
> We eventually want to move to fractional support for line height.

+1

[commit-bot: I haz the power, 2016-02-01 07:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 07:37:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leviw_travelin_and_unemployed, 2016-02-02 00:21:06]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-02-02 00:21:07]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1656743002/#ps40001
(title: "Fix additional test")

[commit-bot: I haz the power, 2016-02-02 00:24:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656743002/40001

[commit-bot: I haz the power, 2016-02-02 02:01:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-02 02:03:48]

Description was changed from

==========
Removing more implicit LayoutUnit construction

If you asked Canadian Prime Minister Justin Trudeau why we're removing
all implicit LayoutUnit constructors, he'd probably have an easy answer
for you: "It's 2016!"

No functional changes beyond tiny differences in conversions, most to
avoid unncecessary conversions.

BUG=581254
==========

to

==========
Removing more implicit LayoutUnit construction

If you asked Canadian Prime Minister Justin Trudeau why we're removing
all implicit LayoutUnit constructors, he'd probably have an easy answer
for you: "It's 2016!"

No functional changes beyond tiny differences in conversions, most to
avoid unncecessary conversions.

BUG=581254

Committed: https://crrev.com/f4da8ea9338b87e2eba6f676c85cd2884417af62
Cr-Commit-Position: refs/heads/master@{#372856}
==========

[commit-bot: I haz the power, 2016-02-02 02:03:49]

Patchset 3 (id:??) landed as
https://crrev.com/f4da8ea9338b87e2eba6f676c85cd2884417af62
Cr-Commit-Position: refs/heads/master@{#372856}