third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp - Issue 1656743002: Removing more implicit LayoutUnit construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

Issue 1656743002: Removing more implicit LayoutUnit construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

diff --git a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

index 1278b03263c78c4d1016ebf3d124beaf1e5ceae0..9b741577f83baaed5b2a4b1fd2807b5361a86e83 100644

--- a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

+++ b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

@@ -184,7 +184,7 @@ void TableLayoutAlgorithmFixed::applyPreferredLogicalWidthQuirks(LayoutUnit& min

{

Length tableLogicalWidth = m_table->style()->logicalWidth();

if (tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive()) {

- minWidth = maxWidth = max(minWidth, LayoutUnit(tableLogicalWidth.value() - m_table->bordersPaddingAndSpacingInRowDirection())).floor();

+ minWidth = maxWidth = LayoutUnit(max(minWidth, LayoutUnit(tableLogicalWidth.value() - m_table->bordersPaddingAndSpacingInRowDirection())).floor());

}

@@ -200,7 +200,7 @@ void TableLayoutAlgorithmFixed::applyPreferredLogicalWidthQuirks(LayoutUnit& min

// We can achieve this effect by making the maxwidth of fixed tables with percentage

// widths be infinite.

if (m_table->style()->logicalWidth().hasPercent() && maxWidth < tableMaxWidth)

- maxWidth = tableMaxWidth;

+ maxWidth = LayoutUnit(tableMaxWidth);

}

void TableLayoutAlgorithmFixed::layout()