third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp - Issue 1656743002: Removing more implicit LayoutUnit construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

Issue 1656743002: Removing more implicit LayoutUnit construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp b/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

index e5cb0ebb558a55376768e2ab82689b896cb2c558..f07ea44a177efefcfb72313c66132ca3666e96fe 100644

--- a/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

@@ -129,7 +129,7 @@ void LayoutSliderContainer::layout()

double percentageOffset = sliderPosition(input).toDouble();

LayoutUnit availableExtent = isVertical ? track->contentHeight() : track->contentWidth();

availableExtent -= isVertical ? thumb->size().height() : thumb->size().width();

- LayoutUnit offset = percentageOffset * availableExtent;

+ LayoutUnit offset(percentageOffset * availableExtent);

LayoutPoint thumbLocation = thumb->location();

if (isVertical)

thumbLocation.setY(thumbLocation.y() + track->contentHeight() - thumb->size().height() - offset);