third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp - Issue 1656743002: Removing more implicit LayoutUnit construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

Issue 1656743002: Removing more implicit LayoutUnit construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

index 3affbcf2f759d4aa4c7ef8d80ca284e7152b5232..ddcc00e33cc50c04dc97abf6a1e2dfaae794a703 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

@@ -391,14 +391,14 @@ LayoutUnit LayoutTextControlSingleLine::scrollHeight() const

LayoutUnit LayoutTextControlSingleLine::scrollLeft() const

{

if (innerEditorElement())

- return innerEditorElement()->scrollLeft();

+ return LayoutUnit(innerEditorElement()->scrollLeft());

return LayoutBlockFlow::scrollLeft();

}

LayoutUnit LayoutTextControlSingleLine::scrollTop() const

{

if (innerEditorElement())

- return innerEditorElement()->scrollTop();

+ return LayoutUnit(innerEditorElement()->scrollTop());

return LayoutBlockFlow::scrollTop();

}