Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 1654513003: Simplify message parsing. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_done
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify message parsing. Previously ProtobufMessageParser was used to parse incoming messages. Removed it and replaced with ParseMessage() function. This allows to simplify MessageReader and makes it possible to remove MessageReader dependency in ChannelDispatcherBase, which will be done later. Committed: https://crrev.com/d8af2cac5ff24fd870df3f21e2b9d47a45ffc469 Cr-Commit-Position: refs/heads/master@{#372526}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -173 lines) Patch
M remoting/protocol/audio_reader.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/protocol/audio_reader.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M remoting/protocol/audio_writer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/audio_writer.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M remoting/protocol/channel_dispatcher_base.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/channel_multiplexer.h View 3 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.h View 2 chunks +3 lines, -6 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M remoting/protocol/client_event_dispatcher.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/client_event_dispatcher.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/protocol/client_video_dispatcher.h View 3 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/client_video_dispatcher.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M remoting/protocol/client_video_dispatcher_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M remoting/protocol/host_control_dispatcher.h View 3 chunks +3 lines, -7 lines 0 comments Download
M remoting/protocol/host_control_dispatcher.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M remoting/protocol/host_event_dispatcher.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M remoting/protocol/host_event_dispatcher.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/protocol/host_video_dispatcher.h View 2 chunks +2 lines, -6 lines 0 comments Download
M remoting/protocol/host_video_dispatcher.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/ice_connection_to_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/message_reader.h View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/protocol/message_reader.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/message_serialization.h View 2 chunks +13 lines, -0 lines 0 comments Download
D remoting/protocol/protobuf_message_parser.h View 1 chunk +0 lines, -62 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
4 years, 6 months ago (2016-01-30 00:42:22 UTC) #3
Jamie
lgtm https://codereview.chromium.org/1654513003/diff/1/remoting/protocol/channel_dispatcher_base.h File remoting/protocol/channel_dispatcher_base.h (right): https://codereview.chromium.org/1654513003/diff/1/remoting/protocol/channel_dispatcher_base.h#newcode60 remoting/protocol/channel_dispatcher_base.h:60: virtual void OnIncomingMessage(scoped_ptr<CompoundBuffer> message); Is the case for ...
4 years, 6 months ago (2016-01-30 00:56:27 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/1654513003/diff/1/remoting/protocol/channel_dispatcher_base.h File remoting/protocol/channel_dispatcher_base.h (right): https://codereview.chromium.org/1654513003/diff/1/remoting/protocol/channel_dispatcher_base.h#newcode60 remoting/protocol/channel_dispatcher_base.h:60: virtual void OnIncomingMessage(scoped_ptr<CompoundBuffer> message); On 2016/01/30 00:56:27, Jamie wrote: ...
4 years, 6 months ago (2016-01-30 02:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654513003/20001
4 years, 6 months ago (2016-01-30 02:17:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-01-30 03:04:47 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-01-30 03:06:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8af2cac5ff24fd870df3f21e2b9d47a45ffc469
Cr-Commit-Position: refs/heads/master@{#372526}

Powered by Google App Engine
This is Rietveld 408576698