Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: remoting/protocol/host_video_dispatcher.cc

Issue 1654513003: Simplify message parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_done
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/host_video_dispatcher.h ('k') | remoting/protocol/ice_connection_to_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/host_video_dispatcher.cc
diff --git a/remoting/protocol/host_video_dispatcher.cc b/remoting/protocol/host_video_dispatcher.cc
index 0d7c0de53997277767537159cf5f6165dc823b23..ca9b63436d493ac7fb32719b8af1e236a2628bac 100644
--- a/remoting/protocol/host_video_dispatcher.cc
+++ b/remoting/protocol/host_video_dispatcher.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "net/socket/stream_socket.h"
#include "remoting/base/constants.h"
+#include "remoting/proto/video.pb.h"
#include "remoting/protocol/message_serialization.h"
#include "remoting/protocol/video_feedback_stub.h"
@@ -16,12 +17,7 @@ namespace remoting {
namespace protocol {
HostVideoDispatcher::HostVideoDispatcher()
- : ChannelDispatcherBase(kVideoChannelName),
- parser_(
- base::Bind(&HostVideoDispatcher::OnVideoAck, base::Unretained(this)),
- reader()),
- video_feedback_stub_(nullptr) {}
-
+ : ChannelDispatcherBase(kVideoChannelName) {}
HostVideoDispatcher::~HostVideoDispatcher() {}
void HostVideoDispatcher::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
@@ -29,7 +25,11 @@ void HostVideoDispatcher::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
writer()->Write(SerializeAndFrameMessage(*packet), done);
}
-void HostVideoDispatcher::OnVideoAck(scoped_ptr<VideoAck> ack) {
+void HostVideoDispatcher::OnIncomingMessage(
+ scoped_ptr<CompoundBuffer> message) {
+ scoped_ptr<VideoAck> ack = ParseMessage<VideoAck>(message.get());
+ if (!ack)
+ return;
if (video_feedback_stub_)
video_feedback_stub_->ProcessVideoAck(std::move(ack));
}
« no previous file with comments | « remoting/protocol/host_video_dispatcher.h ('k') | remoting/protocol/ice_connection_to_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698