Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: remoting/protocol/message_reader.cc

Issue 1654513003: Simplify message parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_done
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/message_reader.h ('k') | remoting/protocol/message_reader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/message_reader.cc
diff --git a/remoting/protocol/message_reader.cc b/remoting/protocol/message_reader.cc
index 44389d71473d6dc54a7bf7ac9333cfa1ef76d3af..3516595e85330a03ccbe436ef6f652c3e6a6b0e8 100644
--- a/remoting/protocol/message_reader.cc
+++ b/remoting/protocol/message_reader.cc
@@ -26,20 +26,18 @@ static const int kReadBufferSize = 4096;
MessageReader::MessageReader() : weak_factory_(this) {}
MessageReader::~MessageReader() {}
-void MessageReader::SetMessageReceivedCallback(
- const MessageReceivedCallback& callback) {
- DCHECK(CalledOnValidThread());
- message_received_callback_ = callback;
-}
-
void MessageReader::StartReading(
P2PStreamSocket* socket,
+ const MessageReceivedCallback& message_received_callback,
const ReadFailedCallback& read_failed_callback) {
DCHECK(CalledOnValidThread());
+ DCHECK(!socket_);
DCHECK(socket);
+ DCHECK(!message_received_callback.is_null());
DCHECK(!read_failed_callback.is_null());
socket_ = socket;
+ message_received_callback_ = message_received_callback;
read_failed_callback_ = read_failed_callback;
DoRead();
}
« no previous file with comments | « remoting/protocol/message_reader.h ('k') | remoting/protocol/message_reader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698