Add the trap instruction to the integrated ARM assembler.

Add the trap instruction to the integrated ARM assembler.

Note: Once this CL has landed, Subzero's "make -f Makeefile.standalone
check-spec" works in the integrated assembler without using hybrid
assembly.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6ddabc17eb7f79e9f6c63174a65380c8fa69c630

[Karl, 2016-01-29 19:18:59]

Description was changed from

==========
Add the trap instruction to the integrated ARM assembler.

Note: Once this CL has landed, Subzero's "make -f Makeefile.standalone
check-spec" works in the integrated assembler without using hybrid
assembly.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add the trap instruction to the integrated ARM assembler.

Note: Once this CL has landed, Subzero's "make -f Makeefile.standalone
check-spec" works in the integrated assembler without using hybrid
assembly.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-01-29 19:18:59]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2016-01-29 20:23:01]

lgtm

[Karl, 2016-01-29 20:24:03]

Description was changed from

==========
Add the trap instruction to the integrated ARM assembler.

Note: Once this CL has landed, Subzero's "make -f Makeefile.standalone
check-spec" works in the integrated assembler without using hybrid
assembly.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add the trap instruction to the integrated ARM assembler.

Note: Once this CL has landed, Subzero's "make -f Makeefile.standalone
check-spec" works in the integrated assembler without using hybrid
assembly.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-29 20:24:05]

Committed patchset #2 (id:20001) manually as
6ddabc17eb7f79e9f6c63174a65380c8fa69c630 (presubmit successful).

[Jim Stichnoth, 2016-01-29 20:49:54]

https://codereview.chromium.org/1649053002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/trap.ll (right):

https://codereview.chromium.org/1649053002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/trap.ll:3: ; Note: We use integer division to test
this, since a trap is inserted
Could you also test the "unreachable" bitcode instruction?

https://codereview.chromium.org/1649053002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/trap.ll:34: ; DIS:        18:	1a000000
tabs

[Karl, 2016-01-29 22:00:37]

See CL https://codereview.chromium.org/1654483002 for fix.

https://codereview.chromium.org/1649053002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/trap.ll (right):

https://codereview.chromium.org/1649053002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/trap.ll:3: ; Note: We use integer division to test
this, since a trap is inserted
On 2016/01/29 20:49:53, stichnot wrote:
> Could you also test the "unreachable" bitcode instruction?

Done.