Issue 1654483002: Fix nits in committed CL's for the integrated ARM assembler.

Issue 1654483002: Fix nits in committed CL's for the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl

Modified:
4 years, 10 months ago

Reviewers:
Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix nits in committed CL's for the integrated ARM assembler. Fixes issues raised after committing the following CLs: https://codereview.chromium.org/1649053002 https://codereview.chromium.org/1647113003 Also generates a trap instruction if hybrid assembly is turned off, and the skip implementation command line flag is turned on. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=81747d6275658119113b02f7da24c5d3fa79a2f0

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -10 lines)			Patch
	M	src/IceInstARM32.cpp	View		2 chunks	+7 lines, -3 lines	0 comments	Download
	M	tests_lit/assembler/arm32/trap.ll	View		2 chunks	+20 lines, -7 lines	0 comments	Download

Total messages: 6 (3 generated)

Karl

4 years, 10 months ago (2016-02-01 18:06:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81747d6275658119113b02f7da24c5d3fa79a2f0 (presubmit successful).