mojo/public/bindings/generators/js_templates/module.js.tmpl - Issue 164873002: Fix bug with using enums as default values in mojom. We were previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/js_templates/module.js.tmpl

Issue 164873002: Fix bug with using enums as default values in mojom. We were previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/public/bindings/generators/js_templates/interface_definition.tmpl ('k') | mojo/public/bindings/generators/js_templates/struct_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/bindings/generators/js_templates/module.js.tmpl

diff --git a/mojo/public/bindings/generators/js_templates/module.js.tmpl b/mojo/public/bindings/generators/js_templates/module.js.tmpl

index 2fb3c0e70629a0bf4a04d3fd5a328da169fe8a13..3bce1179ea2658713d8a9d1a80cd3322d541c089 100644

--- a/mojo/public/bindings/generators/js_templates/module.js.tmpl

+++ b/mojo/public/bindings/generators/js_templates/module.js.tmpl

@@ -15,14 +15,14 @@ define([

) {

{#--- Enums #}

-{%- from "enum_definition.tmpl" import enum_def -%}

+{% from "enum_definition.tmpl" import enum_def -%}

{% for enum in enums %}

-{{ enum_def("var %s"|format(enum.name), enum) }}

+ var {{ enum_def(enum.name, enum, module) }}

{%- endfor %}

{#--- Struct definitions #}

{% for struct in structs %}

-{% include "struct_definition.tmpl" %}

+{%- include "struct_definition.tmpl" %}

{%- endfor %}

{#--- Interface definitions #}