mojo/public/bindings/generators/js_templates/struct_definition.tmpl - Issue 164873002: Fix bug with using enums as default values in mojom. We were previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/js_templates/struct_definition.tmpl

Issue 164873002: Fix bug with using enums as default values in mojom. We were previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/public/bindings/generators/js_templates/module.js.tmpl ('k') | mojo/public/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/bindings/generators/js_templates/struct_definition.tmpl

diff --git a/mojo/public/bindings/generators/js_templates/struct_definition.tmpl b/mojo/public/bindings/generators/js_templates/struct_definition.tmpl

index 4c66df267e187329a32985cab16f91bd3e3dee54..e80e675988c00cf7048c92a3e81888a88848b239 100644

--- a/mojo/public/bindings/generators/js_templates/struct_definition.tmpl

+++ b/mojo/public/bindings/generators/js_templates/struct_definition.tmpl

@@ -1,7 +1,7 @@

{%- macro set_default(kind, value, depth) -%}

{#--- Strings ---#}

{%- if kind|is_string_kind -%}

-{{caller(value)}}

+{{caller(value|expression_to_text(module))}}

{#--- Arrays ---#}

{%- elif kind|is_array_kind %}

{%- set _ = value|verify_token_type("ARRAY") %}

@@ -35,11 +35,12 @@ tmp{{depth}}.{{subfield.name}} = {{result}};

}

{#--- POD types ---#}

{%- else -%}

-{{caller(value|substitute_namespace(imports))}}

+{{caller(value|expression_to_text(module))}}

{%- endif %}

{%- endmacro %}

+{#--- Begin #}

function {{struct.name}}() {

{%- for packed_field in struct.packed.packed_fields %}

{%- if packed_field.field.default %}