mojo/public/bindings/generators/js_templates/interface_definition.tmpl - Issue 164873002: Fix bug with using enums as default values in mojom. We were previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/js_templates/interface_definition.tmpl

Issue 164873002: Fix bug with using enums as default values in mojom. We were previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/public/bindings/generators/js_templates/enum_definition.tmpl ('k') | mojo/public/bindings/generators/js_templates/module.js.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/bindings/generators/js_templates/interface_definition.tmpl

diff --git a/mojo/public/bindings/generators/js_templates/interface_definition.tmpl b/mojo/public/bindings/generators/js_templates/interface_definition.tmpl

index fd5e27a43c384576cd8f6b95e00dd2cbf7164b41..df1483d1063bac333be991a66e3a729bb4d19180 100644

--- a/mojo/public/bindings/generators/js_templates/interface_definition.tmpl

+++ b/mojo/public/bindings/generators/js_templates/interface_definition.tmpl

@@ -46,8 +46,8 @@ params.{{parameter.name}}{% if not loop.last %}, {% endif %}

};

{#--- Enums #}

-{%- from "enum_definition.tmpl" import enum_def -%}

+{% from "enum_definition.tmpl" import enum_def -%}

{% for enum in interface.enums %}

-{{ enum_def("%sProxy.%s"|format(interface.name, enum.name), enum)}}

+ {{enum_def("%sProxy.%s"|format(interface.name, enum.name), enum, module)}}

{{interface.name}}Stub.{{enum.name}} = {{interface.name}}Proxy.{{enum.name}};

{%- endfor %}