Fix bug with using enums as default values in mojom. We were previously

mojo/apps/js/bindings/sample_service_unittests.js

Index: mojo/apps/js/bindings/sample_service_unittests.js
diff --git a/mojo/apps/js/bindings/sample_service_unittests.js b/mojo/apps/js/bindings/sample_service_unittests.js
index 299292676702e1c247751d8bba535ae21159fa80..0bcaa30eb22d30119e388e30a9d0d94380fbacab 100644
--- a/mojo/apps/js/bindings/sample_service_unittests.js
+++ b/mojo/apps/js/bindings/sample_service_unittests.js
@@ -8,7 +8,8 @@ define([
     "gin/test/expect",
     "mojom/sample_service",
     "mojom/sample_import",
-  ], function(console, hexdump, expect, sample, imported) {
+    "mojom/sample_import2",
+  ], function(console, hexdump, expect, sample, imported, imported2) {
 
   var global = this;
 
@@ -117,12 +118,10 @@ define([
     expect(full.point.y).toBe(15);
 
     expect(full.shape_masks.length).toBe(1);
-    // TODO(mpcomplete): This is broken.
-    // http://crbug.com/320082
-    // expect(full.shape_masks[0]).toBe(1 << imported.Shape.SHAPE_RECTANGLE);
+    expect(full.shape_masks[0]).toBe(1 << imported.Shape.SHAPE_RECTANGLE);
 
-    //expect(full.thing.shape).toBe(imported.Shape.SHAPE_RECTANGLE);
-    //expect(full.thing.color).toBe(imported.Color.COLOR_RED);
+    expect(full.thing.shape).toBe(imported.Shape.SHAPE_CIRCLE);
+    expect(full.thing.color).toBe(imported2.Color.COLOR_BLACK);

[darin (slow to review), 2014/02/13 22:55:21]

Note: it seems like it would be nice if we generated "Color.BLACK" here instead.
Having to type the word "color" twice seems of no value.

Maybe we could address this by changing the way we generate the enum values in
C++. For C++ we could add the prefix so we don't have to figure out how to
subtract it for JS?

For example the following mojom:

  enum Shape {
    CIRCLE,
    ...
  };

Could generate the following C++:

  enum Shape {
    SHAPE_CIRCLE,
    ...
  };

And then in JS it would be:

  Shape.CIRCLE

Looks good?

[Matt Perry, 2014/02/14 19:43:42]

That's definitely doable. It feels a bit.. dirty to me, somehow. I'll file a bug
on it and maybe I'll warm up to it.

   }
 
   function ServiceImpl() {