Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1648233002: Merge to XFA: Member function name refactoring (Closed)

Created:
4 years, 10 months ago by Wei Li
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Member function name refactoring This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 . (cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b) Committed: https://pdfium.googlesource.com/pdfium/+/9b76113ae4567eb998618d049afde26d3f0175d5

Patch Set 1 : clean merge #

Patch Set 2 : more xfa changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+984 lines, -973 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 3 chunks +30 lines, -28 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 3 chunks +11 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 16 chunks +43 lines, -41 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 8 chunks +28 lines, -28 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 9 chunks +26 lines, -26 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 7 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 12 chunks +17 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 15 chunks +34 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 8 chunks +32 lines, -32 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 18 chunks +21 lines, -21 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 12 chunks +23 lines, -23 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 7 chunks +35 lines, -35 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 12 chunks +23 lines, -23 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 10 chunks +30 lines, -29 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 18 chunks +47 lines, -46 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 14 chunks +32 lines, -32 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 18 chunks +36 lines, -36 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 19 chunks +50 lines, -49 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 9 chunks +26 lines, -26 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 11 chunks +24 lines, -24 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 22 chunks +38 lines, -38 lines 0 comments Download
M core/src/fpdfdoc/doc_viewerPreferences.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 9 chunks +23 lines, -22 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 13 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 17 chunks +42 lines, -42 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 9 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 9 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Wei Li
Merge itself is clean. Function names in several xfa files need to be changed as ...
4 years, 10 months ago (2016-01-29 23:17:03 UTC) #1
Lei Zhang
On 2016/01/29 23:17:03, Wei Li wrote: > Merge itself is clean. Function names in several ...
4 years, 10 months ago (2016-01-29 23:18:46 UTC) #2
Wei Li
On 2016/01/29 23:18:46, Lei Zhang wrote: > On 2016/01/29 23:17:03, Wei Li wrote: > > ...
4 years, 10 months ago (2016-01-29 23:26:10 UTC) #4
Lei Zhang
lgtm
4 years, 10 months ago (2016-01-29 23:28:07 UTC) #5
Wei Li
4 years, 10 months ago (2016-01-29 23:44:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
9b76113ae4567eb998618d049afde26d3f0175d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698