Merge to XFA: Member function name refactoring

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdfview.h"
 
 #include <memory>
 
@@ skipping 329 matching lines @@
 
   CPDF_Document* pdfDoc =
       (static_cast<CPDFXFA_Document*>(document))->GetPDFDoc();
   if (!pdfDoc)
     return FALSE;
 
   CPDF_Dictionary* pRoot = pdfDoc->GetRoot();
   if (!pRoot)
     return FALSE;
 
-  CPDF_Dictionary* pAcroForm = pRoot->GetDict("AcroForm");
+  CPDF_Dictionary* pAcroForm = pRoot->GetDictBy("AcroForm");
   if (!pAcroForm)
     return FALSE;
 
   CPDF_Object* pXFA = pAcroForm->GetElement("XFA");
   if (!pXFA)
     return FALSE;
 
-  FX_BOOL bDynamicXFA = pRoot->GetBoolean("NeedsRendering", FALSE);
+  FX_BOOL bDynamicXFA = pRoot->GetBooleanBy("NeedsRendering", FALSE);
 
   if (bDynamicXFA)
     *docType = DOCTYPE_DYNAMIC_XFA;
   else
     *docType = DOCTYPE_STATIC_XFA;
 
   return TRUE;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_LoadXFA(FPDF_DOCUMENT document) {
@@ skipping 87 matching lines @@
 DLLEXPORT unsigned long STDCALL FPDF_GetDocPermissions(FPDF_DOCUMENT document) {
   CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(document);
   if (!pDoc)
 #ifndef PDF_ENABLE_XFA
     return 0;
 #else   // PDF_ENABLE_XFA
     return (FX_DWORD)-1;
 #endif  // PDF_ENABLE_XFA
 
   CPDF_Dictionary* pDict = pDoc->GetParser()->GetEncryptDict();
-  return pDict ? pDict->GetInteger("P") : (FX_DWORD)-1;
+  return pDict ? pDict->GetIntegerBy("P") : (FX_DWORD)-1;
 }
 
 DLLEXPORT int STDCALL FPDF_GetSecurityHandlerRevision(FPDF_DOCUMENT document) {
   CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(document);
   if (!pDoc)
     return -1;
 
   CPDF_Dictionary* pDict = pDoc->GetParser()->GetEncryptDict();
-  return pDict ? pDict->GetInteger("R") : -1;
+  return pDict ? pDict->GetIntegerBy("R") : -1;
 }
 
 DLLEXPORT int STDCALL FPDF_GetPageCount(FPDF_DOCUMENT document) {
   UnderlyingDocumentType* pDoc = UnderlyingFromFPDFDocument(document);
   return pDoc ? pDoc->GetPageCount() : 0;
 }
 
 DLLEXPORT FPDF_PAGE STDCALL FPDF_LoadPage(FPDF_DOCUMENT document,
                                           int page_index) {
   UnderlyingDocumentType* pDoc = UnderlyingFromFPDFDocument(document);
@@ skipping 561 matching lines @@
   CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(document);
   if (!pDoc)
     return 0;
 
   CPDF_Dictionary* pRoot = pDoc->GetRoot();
   if (!pRoot)
     return 0;
 
   CPDF_NameTree nameTree(pDoc, "Dests");
   pdfium::base::CheckedNumeric<FPDF_DWORD> count = nameTree.GetCount();
-  CPDF_Dictionary* pDest = pRoot->GetDict("Dests");
+  CPDF_Dictionary* pDest = pRoot->GetDictBy("Dests");
   if (pDest)
     count += pDest->GetCount();
 
   if (!count.IsValid())
     return 0;
 
   return count.ValueOrDie();
 }
 
 DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDestByName(FPDF_DOCUMENT document,
@@ skipping 79 matching lines @@
 
   CPDF_Dictionary* pRoot = pDoc->GetRoot();
   if (!pRoot)
     return nullptr;
 
   CPDF_Object* pDestObj = nullptr;
   CFX_ByteString bsName;
   CPDF_NameTree nameTree(pDoc, "Dests");
   int count = nameTree.GetCount();
   if (index >= count) {
-    CPDF_Dictionary* pDest = pRoot->GetDict("Dests");
+    CPDF_Dictionary* pDest = pRoot->GetDictBy("Dests");
     if (!pDest)
       return nullptr;
 
     pdfium::base::CheckedNumeric<int> checked_count = count;
     checked_count += pDest->GetCount();
     if (!checked_count.IsValid() || index >= checked_count.ValueOrDie())
       return nullptr;
 
     index -= count;
     int i = 0;
     for (const auto& it : *pDest) {
       bsName = it.first;
       pDestObj = it.second;
       if (!pDestObj)
         continue;
       if (i == index)
         break;
       i++;
     }
   } else {
     pDestObj = nameTree.LookupValue(index, bsName);
   }
   if (!pDestObj)
     return nullptr;
   if (CPDF_Dictionary* pDict = pDestObj->AsDictionary()) {
-    pDestObj = pDict->GetArray("D");
+    pDestObj = pDict->GetArrayBy("D");
     if (!pDestObj)
       return nullptr;
   }
   if (!pDestObj->IsArray())
     return nullptr;
 
   CFX_WideString wsName = PDF_DecodeText(bsName);
   CFX_ByteString utf16Name = wsName.UTF16LE_Encode();
   unsigned int len = utf16Name.GetLength();
   if (!buffer) {
     *buflen = len;
   } else if (*buflen >= len) {
     memcpy(buffer, utf16Name.c_str(), len);
     *buflen = len;
   } else {
     *buflen = -1;
   }
   return (FPDF_DEST)pDestObj;
 }