Merge to XFA: Member function name refactoring

core/src/fpdfdoc/doc_link.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
 
 CPDF_LinkList::CPDF_LinkList() {
 }
@@ skipping 38 matching lines @@
 
     if (z_order)
       *z_order = annot_index;
     return link;
   }
   return CPDF_Link();
 }
 
 void CPDF_LinkList::LoadPageLinks(CPDF_Page* pPage,
                                   std::vector<CPDF_Dictionary*>* pList) {
-  CPDF_Array* pAnnotList = pPage->m_pFormDict->GetArray("Annots");
+  CPDF_Array* pAnnotList = pPage->m_pFormDict->GetArrayBy("Annots");
   if (!pAnnotList)
     return;
 
   for (FX_DWORD i = 0; i < pAnnotList->GetCount(); ++i) {
-    CPDF_Dictionary* pAnnot = pAnnotList->GetDict(i);
-    bool add_link = (pAnnot && pAnnot->GetString("Subtype") == "Link");
+    CPDF_Dictionary* pAnnot = pAnnotList->GetDictAt(i);
+    bool add_link = (pAnnot && pAnnot->GetStringBy("Subtype") == "Link");
     // Add non-links as nullptrs to preserve z-order.
     pList->push_back(add_link ? pAnnot : nullptr);
   }
 }
 
 CPDF_Rect CPDF_Link::GetRect() {
-  return m_pDict->GetRect("Rect");
+  return m_pDict->GetRectBy("Rect");
 }
 CPDF_Dest CPDF_Link::GetDest(CPDF_Document* pDoc) {
   CPDF_Object* pDest = m_pDict->GetElementValue("Dest");
   if (!pDest)
     return CPDF_Dest();
 
   if (pDest->IsString() || pDest->IsName()) {
     CPDF_NameTree name_tree(pDoc, "Dests");
     CFX_ByteStringC name = pDest->GetString();
     return CPDF_Dest(name_tree.LookupNamedDest(pDoc, name));
   }
   if (CPDF_Array* pArray = pDest->AsArray())
     return CPDF_Dest(pArray);
   return CPDF_Dest();
 }
 CPDF_Action CPDF_Link::GetAction() {
-  return CPDF_Action(m_pDict->GetDict("A"));
+  return CPDF_Action(m_pDict->GetDictBy("A"));
 }