Member function name refactoring

Member function name refactoring

This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d45e7a51904164fb22049f0a7a80d2a94c06936b

[Wei Li, 2016-01-27 19:14:05]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-01-27 19:14:37]

Description was changed from

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collsion with virtual functions
will be shown as warnings on Linux. Also, it is a better practice to use
different names for different cases.
==========

to

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collsion with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
==========

[Wei Li, 2016-01-27 19:14:48]

Description was changed from

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collsion with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
==========

to

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
==========

[Wei Li, 2016-01-27 19:36:12]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-01-27 19:36:13]

Turned out this change is needed for refactoring CPDF_Object and its subclasses.
Is there a workaround?

[Lei Zhang, 2016-01-27 23:21:07]

On 2016/01/27 19:36:13, Wei Li wrote:
> Turned out this change is needed for refactoring CPDF_Object and its
subclasses.
> Is there a workaround?

I vaguely remember this because I tried to unsuccessfully refactor CPDF_Object
once. LGTM based on spot checks.

[Lei Zhang, 2016-01-28 04:03:53]

On 2016/01/27 23:21:07, Lei Zhang wrote:
> On 2016/01/27 19:36:13, Wei Li wrote:
> > Turned out this change is needed for refactoring CPDF_Object and its
> subclasses.
> > Is there a workaround?
> 
> I vaguely remember this because I tried to unsuccessfully refactor CPDF_Object
> once. LGTM based on spot checks.

Ya, I tried here: https://codereview.chromium.org/1194933003/ and never
finished.

[Wei Li, 2016-01-28 23:59:44]

Description was changed from

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
==========

to

==========
Member function name refactoring

This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/d45e7a51904164fb22049f0a7a80d2a94c06...
==========

[Wei Li, 2016-01-28 23:59:46]

Committed patchset #1 (id:20001) manually as
d45e7a51904164fb22049f0a7a80d2a94c06936b (presubmit successful).