Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1647313003: Continue converting to explicit LayoutUnit constructors (Closed)

Created:
4 years, 10 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jbroman, jchaffraix+rendering, jfernandez, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, svillar, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@explicitContstructors
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Continue converting to explicit LayoutUnit constructors Still a work in progress. BUG=581254 Committed: https://crrev.com/9dbe383187aae9b2017bec82d9d5e715b157933a Cr-Commit-Position: refs/heads/master@{#372539}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ToT-ed #

Patch Set 3 : Address comments #

Patch Set 4 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -195 lines) Patch
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 21 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 19 chunks +31 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 6 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 2 4 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/OverflowModelTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineInfo.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineLayoutState.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfoTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRect.h View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1648573002 Patch 140001

Dependent Patchsets:

Issue 1653673002 Patch 20001
Issue 1653673002 Patch 40001

Messages

Total messages: 12 (4 generated)
leviw_travelin_and_unemployed
4 years, 10 months ago (2016-01-29 23:46:27 UTC) #2
eae
LGTM w/suggestions https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/ColumnBalancer.h File third_party/WebKit/Source/core/layout/ColumnBalancer.h (right): https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/ColumnBalancer.h#newcode137 third_party/WebKit/Source/core/layout/ColumnBalancer.h:137: return LayoutUnit(ceilf((m_breakOffset - startOffset).toFloat() / float(m_assumedImplicitBreaks + ...
4 years, 10 months ago (2016-01-29 23:57:42 UTC) #3
leviw_travelin_and_unemployed
On 2016/01/29 at 23:57:42, eae wrote: > LGTM w/suggestions > > https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/ColumnBalancer.h > File third_party/WebKit/Source/core/layout/ColumnBalancer.h ...
4 years, 10 months ago (2016-01-30 02:42:02 UTC) #4
eae
> https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp > > File third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp > (right): > > > > > https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp#newcode65 > ...
4 years, 10 months ago (2016-01-30 02:43:23 UTC) #5
leviw_travelin_and_unemployed
On 2016/01/29 at 23:57:42, eae wrote: > LGTM w/suggestions > > https://codereview.chromium.org/1647313003/diff/1/third_party/WebKit/Source/core/layout/ColumnBalancer.h > File third_party/WebKit/Source/core/layout/ColumnBalancer.h ...
4 years, 10 months ago (2016-01-30 04:54:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647313003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647313003/60001
4 years, 10 months ago (2016-01-30 04:56:10 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-01-30 06:15:08 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 06:16:05 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9dbe383187aae9b2017bec82d9d5e715b157933a
Cr-Commit-Position: refs/heads/master@{#372539}

Powered by Google App Engine
This is Rietveld 408576698