third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp - Issue 1647313003: Continue converting to explicit LayoutUnit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

Issue 1647313003: Continue converting to explicit LayoutUnit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicitContstructors

Patch Set: Add TODO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

index 330d2954b0279f7e8b74ebff46c3cb647ef5f2cb..c62946e1c6896bb4809b8be9f4e1b79de0b9b381 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

@@ -116,7 +116,7 @@ TEST_F(LayoutObjectTest, MapToVisibleRectInContainerSpace)

LayoutBlock* container = toLayoutBlock(document().getElementById("container")->layoutObject());

LayoutText* text = toLayoutText(container->lastChild());

- container->setScrollTop(50);

+ container->setScrollTop(LayoutUnit(50));

LayoutRect rect(0, 60, 20, 20);

text->mapToVisibleRectInAncestorSpace(container, rect, nullptr);

EXPECT_TRUE(rect == LayoutRect(0, 10, 20, 20));