third_party/WebKit/Source/core/layout/OverflowModelTest.cpp - Issue 1647313003: Continue converting to explicit LayoutUnit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/OverflowModelTest.cpp

Issue 1647313003: Continue converting to explicit LayoutUnit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicitContstructors

Patch Set: Add TODO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | third_party/WebKit/Source/core/layout/api/LineLayoutBlockFlow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/OverflowModelTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/OverflowModelTest.cpp b/third_party/WebKit/Source/core/layout/OverflowModelTest.cpp

index 38ff381894360e7bf9bfb0fb9af162889fef8a36..27f0877adbf79a0999945b671375ee7cf6cacd15 100644

--- a/third_party/WebKit/Source/core/layout/OverflowModelTest.cpp

+++ b/third_party/WebKit/Source/core/layout/OverflowModelTest.cpp

@@ -157,20 +157,20 @@ TEST_F(OverflowModelTest, AddContentsVisualOverflowEmpty)

TEST_F(OverflowModelTest, MoveAffectsLayoutOverflow)

{

- m_overflow.move(500, 100);

+ m_overflow.move(LayoutUnit(500), LayoutUnit(100));

EXPECT_EQ(LayoutRect(510, 110, 80, 80), m_overflow.layoutOverflowRect());

}

TEST_F(OverflowModelTest, MoveAffectsVisualOverflow)

{

- m_overflow.move(500, 100);

+ m_overflow.move(LayoutUnit(500), LayoutUnit(100));

EXPECT_EQ(LayoutRect(500, 100, 100, 100), m_overflow.visualOverflowRect());

}

TEST_F(OverflowModelTest, MoveAffectsContentsVisualOverflow)

{

m_overflow.addContentsVisualOverflow(LayoutRect(0, 0, 10, 10));

- m_overflow.move(500, 100);

+ m_overflow.move(LayoutUnit(500), LayoutUnit(100));

EXPECT_EQ(LayoutRect(500, 100, 10, 10), m_overflow.contentsVisualOverflowRect());

}