third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp - Issue 1647313003: Continue converting to explicit LayoutUnit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp

Issue 1647313003: Continue converting to explicit LayoutUnit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicitContstructors

Patch Set: Add TODO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp b/third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp

index 2d4f4ed0347b987b5a12e63fa2baaa1dca5f630f..78c62082ea72941c21bcb83e6e7fd1d8523cefa6 100644

--- a/third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp

@@ -82,15 +82,15 @@ TEST_F(BoxShapeTest, zeroRadii)

// Similarly a "line", specified as top,height to the overlap methods,

// is defined as top <= y < top + height.

- EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(-9, 1));

- EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(-10, 0));

- EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(-10, 200));

- EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(5, 10));

- EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(59, 1));

- EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(-12, 2));

- EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(60, 1));

- EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(100, 200));

+ EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(-9), LayoutUnit(1)));

+ EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(-10), LayoutUnit(0)));

+ EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(-10), LayoutUnit(200)));

+ EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(5), LayoutUnit(10)));

+ EXPECT_TRUE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(59), LayoutUnit(1)));

+ EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(-12), LayoutUnit(2)));

+ EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(60), LayoutUnit(1)));

+ EXPECT_FALSE(shape->lineOverlapsShapeMarginBounds(LayoutUnit(100), LayoutUnit(200)));

TEST_EXCLUDED_INTERVAL(shape, -9, 1, -10, 110);

TEST_EXCLUDED_INTERVAL(shape, -10, 0, -10, 110);