Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1647113003: Add VSQRT instruction to the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add VSQRT instruction to the integrated ARM assembler. Also fixes the non-hybrid ARM assembler to display the instruction it can't translate, making it easier to see what can't be handled. This change was added to see what still isn't being translated in spec2k performance tests. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=266c5a25bb8c07b691aa6396ccef6f8d37df9cd0

Patch Set 1 #

Patch Set 2 : Update DART files. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -7 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M src/IceInstARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 3 chunks +28 lines, -4 lines 2 comments Download
A tests_lit/assembler/arm32/vsqrt.ll View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Karl
4 years, 10 months ago (2016-01-29 17:15:28 UTC) #3
John
lgtm
4 years, 10 months ago (2016-01-29 17:22:50 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as 266c5a25bb8c07b691aa6396ccef6f8d37df9cd0 (presubmit successful).
4 years, 10 months ago (2016-01-29 17:55:01 UTC) #6
Jim Stichnoth
https://codereview.chromium.org/1647113003/diff/20001/src/IceInstARM32.cpp File src/IceInstARM32.cpp (right): https://codereview.chromium.org/1647113003/diff/20001/src/IceInstARM32.cpp#newcode1704 src/IceInstARM32.cpp:1704: llvm::report_fatal_error("Vqrt of non-floating type"); Vsqrt
4 years, 10 months ago (2016-01-29 20:48:02 UTC) #7
Karl
4 years, 10 months ago (2016-01-29 22:00:55 UTC) #8
Message was sent while issue was closed.
See CL https://codereview.chromium.org/1654483002 for fix.

https://codereview.chromium.org/1647113003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1647113003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1704: llvm::report_fatal_error("Vqrt of non-floating
type");
On 2016/01/29 20:48:02, stichnot wrote:
> Vsqrt

Done.

Powered by Google App Engine
This is Rietveld 408576698