Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1643663002: Conditionally create PaintLayer's scrollable area object (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Conditionally create PaintLayer's scrollable area object BUG=467721 Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e Cr-Commit-Position: refs/heads/master@{#378247}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 10

Patch Set 8 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -76 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/mouse-relative-position-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 7 18 chunks +41 lines, -60 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 5 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
Xianzhu
Ptal. https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html File third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html (left): https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html#oldcode101 third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html:101: shouldBe("simulateElementClick(inputElement, [40, 10, 40, 10]);", "'40, 10, 40, ...
4 years, 10 months ago (2016-02-25 19:57:51 UTC) #3
chrishtr
https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBox.cpp File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBox.cpp#newcode259 third_party/WebKit/Source/core/layout/LayoutBox.cpp:259: PaintLayerScrollableArea* scrollableArea = this->scrollableArea(); Here and in the various ...
4 years, 9 months ago (2016-02-26 19:07:42 UTC) #4
Xianzhu
https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBox.cpp File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBox.cpp#newcode259 third_party/WebKit/Source/core/layout/LayoutBox.cpp:259: PaintLayerScrollableArea* scrollableArea = this->scrollableArea(); On 2016/02/26 19:07:42, chrishtr wrote: ...
4 years, 9 months ago (2016-02-26 19:09:55 UTC) #5
chrishtr
https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode309 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:309: && node() != document().viewportDefiningElement(); It seems it would be ...
4 years, 9 months ago (2016-02-26 19:42:17 UTC) #6
Xianzhu
https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1643663002/diff/120001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode309 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:309: && node() != document().viewportDefiningElement(); On 2016/02/26 19:42:16, chrishtr wrote: ...
4 years, 9 months ago (2016-02-26 20:12:57 UTC) #7
chrishtr
lgtm
4 years, 9 months ago (2016-02-26 20:25:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643663002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643663002/140001
4 years, 9 months ago (2016-02-26 20:39:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/28358)
4 years, 9 months ago (2016-02-26 20:47:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643663002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643663002/140001
4 years, 9 months ago (2016-02-26 21:38:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/180753)
4 years, 9 months ago (2016-02-27 00:10:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643663002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643663002/140001
4 years, 9 months ago (2016-02-29 18:01:00 UTC) #18
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-02-29 19:37:48 UTC) #20
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e Cr-Commit-Position: refs/heads/master@{#378247}
4 years, 9 months ago (2016-02-29 19:38:52 UTC) #22
Xianzhu
4 years, 9 months ago (2016-03-02 18:47:42 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1755243002/ by wangxianzhu@chromium.org.

The reason for reverting is: Caused bug 591045. CompositedLayerMapping and
ScrollingCoordinator don't expect scrollableArea of a layer to disappear.

BUG=591045.

Powered by Google App Engine
This is Rietveld 408576698