Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

Issue 1643663002: Conditionally create PaintLayer's scrollable area object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp
index b6cc330f542350bd43bfb3fc6f6ef0ae1c1a6236..26feff5fd0299c0e3cf0c2de986db63b84d4ec08 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp
@@ -35,11 +35,9 @@ LayoutSVGBlock::LayoutSVGBlock(SVGElement* element)
{
}
-void LayoutSVGBlock::updateFromStyle()
+bool LayoutSVGBlock::allowsOverflowClip() const
{
- LayoutBlock::updateFromStyle();
-
- // LayoutSVGlock, used by Layout(SVGText|ForeignObject), is not allowed to call setHasOverflowClip(true).
+ // LayoutSVGlock, used by Layout(SVGText|ForeignObject), is not allowed to have overflow clip.
// LayoutBlock assumes a layer to be present when the overflow clip functionality is requested. Both
// Layout(SVGText|ForeignObject) return 'NoPaintLayer' on 'layerTypeRequired'. Fine for LayoutSVGText.
//
@@ -51,7 +49,7 @@ void LayoutSVGBlock::updateFromStyle()
//
// Note: This does NOT affect overflow handling on outer/inner <svg> elements - this is handled
// manually by LayoutSVGRoot - which owns the documents enclosing root layer and thus works fine.
- setHasOverflowClip(false);
+ return false;
}
void LayoutSVGBlock::absoluteRects(Vector<IntRect>&, const LayoutPoint&) const

Powered by Google App Engine
This is Rietveld 408576698