third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html - Issue 1643663002: Conditionally create PaintLayer's scrollable area object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/mouse-relative-position.html

Issue 1643663002: Conditionally create PaintLayer's scrollable area object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/mouse-relative-position-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <style>	4 <style>

5 html, body {	5 html, body {

6 margin: 0;	6 margin: 0;

7 padding: 0;	7 padding: 0;

8 }	8 }

9	9

10 #test1 {	10 #test1 {

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 return result.join(', ');	91 return result.join(', ');

92 }	92 }

93	93

94 var testElement = document.getElementById('test1');	94 var testElement = document.getElementById('test1');

95 var spanElement = testElement.getElementsByTagName('span')[0];	95 var spanElement = testElement.getElementsByTagName('span')[0];

96 var testElement2 = document.getElementById('test2');	96 var testElement2 = document.getElementById('test2');

97 var inputElement = testElement2.getElementsByTagName('input')[0];	97 var inputElement = testElement2.getElementsByTagName('input')[0];

98	98

99 shouldBe("simulateElementClick(testElement, [100, 100, 200, 200]);", "'100, 100, 200, 200'");	99 shouldBe("simulateElementClick(testElement, [100, 100, 200, 200]);", "'100, 100, 200, 200'");

100 shouldBe("simulateElementClick(spanElement, [16, 10, 16, 10]);", "'16, 10, 1 6, 10'");	100 shouldBe("simulateElementClick(spanElement, [16, 10, 16, 10]);", "'16, 10, 1 6, 10'");

101 shouldBe("simulateElementClick(inputElement, [40, 10, 40, 10]);", "'40, 10, 40, 10'");	101 shouldBe("simulateElementClick(inputElement, [39, 9, 95, 10]);", "'39, 9, 95 , 10'");
Xianzhu 2016/02/25 19:57:51 Actually this was [39, 9, 39, 9] but [40, 10, 40, Actually this was [39, 9, 39, 9] but [40, 10, 40, 10] was also accepted because of TOLERANCE. With the new code, event.layerX (which exposes implementation details and I think should not be part of API) changed from 39 to 95 because the input element no longer create a layer. It unnecessarily created layer because of the temporary hasOverflowClip==true between LayoutBox::updateFromStyle() and LayoutTextControlSingleLine::styleDidChange().
102 </script>	102 </script>

103 </html>	103 </html>

OLD	NEW