third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 1643663002: Conditionally create PaintLayer's scrollable area object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1643663002: Conditionally create PaintLayer's scrollable area object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 473f4583c086fff13d2dca5fc8ce5abccda588f6..ccd79f249db8096dacf60324f06c1af4a52dbc88 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -740,9 +740,7 @@ private:

void updateReflectionInfo(const ComputedStyle*);

FilterEffectBuilder* updateFilterEffectBuilder() const;

- // FIXME: We could lazily allocate our ScrollableArea based on style properties ('overflow', ...)

- // but for now, we are always allocating it for LayoutBox as it's safer. crbug.com/467721.

- bool requiresScrollableArea() const { return layoutBox(); }

+ bool requiresScrollableArea() const { return m_layoutObject->hasOverflowClip() || m_layoutObject->isLayoutView() || m_layoutObject->styleRef().resize() != RESIZE_NONE; }

void updateScrollableArea();

void dirtyAncestorChainVisibleDescendantStatus();