Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1642473002: Revert "Update StyleValue.cssString() to use existing methods instead of rolling our… (Closed)

Created:
4 years, 11 months ago by meade_UTC10
Modified:
4 years, 11 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis, rjwright, lawton, tridgell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Update StyleValue.cssString() to use existing methods instead of rolling our own." This reverts commit 13eeea65976892b0c083bee1f354715bc67e5375. The original CL was suspected of causing an 18.4% regression in dromaeo.domcoreattr at 370280:370316 on Android Galaxy s5, so reverting this to see if the bots recover. reverts: https://codereview.chromium.org/1602843003 BUG=580981 Committed: https://crrev.com/3ed7ab51a276748ecedf6efffe7ea3d8cf883803 Cr-Commit-Position: refs/heads/master@{#372056}

Patch Set 1 #

Patch Set 2 : Make sure it compiles #

Messages

Total messages: 11 (6 generated)
meade_UTC10
4 years, 11 months ago (2016-01-28 06:31:47 UTC) #3
esprehn
lgtm
4 years, 11 months ago (2016-01-28 06:39:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642473002/20001
4 years, 11 months ago (2016-01-28 06:42:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-28 09:38:54 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 09:39:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ed7ab51a276748ecedf6efffe7ea3d8cf883803
Cr-Commit-Position: refs/heads/master@{#372056}

Powered by Google App Engine
This is Rietveld 408576698