Update StyleValue.cssString() to use existing methods instead of rolling our own.

Update StyleValue.cssString() to use existing methods instead of rolling our own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318
Committed: https://crrev.com/13eeea65976892b0c083bee1f354715bc67e5375
Cr-Commit-Position: refs/heads/master@{#370341}

[meade_UTC10, 2016-01-19 05:41:07]

Description was changed from

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

BUG=545318
==========

to

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Also get rid of re-parsing unit types in SimpleLength.toCSSValue.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests.

BUG=545318
==========

[meade_UTC10, 2016-01-19 06:16:43]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-01-19 06:16:43]

Hopefully this is a quick one. Nat pointed out we could simplify this and avoid
code duplication. What do you think?

Eddy

[meade_UTC10, 2016-01-19 06:28:44]

Description was changed from

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Also get rid of re-parsing unit types in SimpleLength.toCSSValue.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests.

BUG=545318
==========

to

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318
==========

[Timothy Loh, 2016-01-19 06:38:13]

On 2016/01/19 06:16:43, Eddy wrote:
> Hopefully this is a quick one. Nat pointed out we could simplify this and
avoid
> code duplication. What do you think?
> 
> Eddy

lgtm, but cssText is not necessarily going to do what you want right now.

> $0.style.width = 'calc(1px + 2% + 3vw)'
> $0.style.width
"calc((1px + 2%) + 3vw)"

[meade_UTC10, 2016-01-20 00:55:03]

On 2016/01/19 06:38:13, Timothy Loh wrote:
> On 2016/01/19 06:16:43, Eddy wrote:
> > Hopefully this is a quick one. Nat pointed out we could simplify this and
> avoid
> > code duplication. What do you think?
> > 
> > Eddy
> 
> lgtm, but cssText is not necessarily going to do what you want right now.
> 
> > $0.style.width = 'calc(1px + 2% + 3vw)'
> > $0.style.width
> "calc((1px + 2%) + 3vw)"

We decided that that's ok.

I also fixed a bug in StyleCalcLength::toCSSValue and added a layout test for
it.

[meade_UTC10, 2016-01-20 05:25:57]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-01-20 05:25:57]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1602843003/#ps140001
(title: "revert TransformValue.html")

[commit-bot: I haz the power, 2016-01-20 05:26:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602843003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602843003/140001

[commit-bot: I haz the power, 2016-01-20 08:47:04]

Description was changed from

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318
==========

to

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318
==========

[commit-bot: I haz the power, 2016-01-20 08:47:05]

Committed patchset #9 (id:140001)

[commit-bot: I haz the power, 2016-01-20 08:47:51]

Description was changed from

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318
==========

to

==========
Update StyleValue.cssString() to use existing methods instead of rolling our
own.

All StyleValues now use toCSSValue()->cssText() instead of defining
custom methods in subclasses.

Conveniently, this effectively allows toCSSValue to be tested in
LayoutTests. Also get rid of re-parsing unit types in
SimpleLength.toCSSValue, since the code there had a bug anyway
which was uncovered by the LayoutTests.

BUG=545318

Committed: https://crrev.com/13eeea65976892b0c083bee1f354715bc67e5375
Cr-Commit-Position: refs/heads/master@{#370341}
==========

[commit-bot: I haz the power, 2016-01-20 08:47:52]

Patchset 9 (id:??) landed as
https://crrev.com/13eeea65976892b0c083bee1f354715bc67e5375
Cr-Commit-Position: refs/heads/master@{#370341}