third_party/WebKit/Source/core/css/cssom/StyleValue.h - Issue 1642473002: Revert "Update StyleValue.cssString() to use existing methods instead of rolling our…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StyleValue.h

Issue 1642473002: Revert "Update StyleValue.cssString() to use existing methods instead of rolling our… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure it compiles Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp ('k') | third_party/WebKit/Source/core/css/cssom/TransformValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StyleValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/StyleValue.h b/third_party/WebKit/Source/core/css/cssom/StyleValue.h

index 06e120f322f9c84282252ddfab1f854e4f2126b6..0d8ff3f0e2e4fbefa8c2bfaec6fdd0f7da43474f 100644

--- a/third_party/WebKit/Source/core/css/cssom/StyleValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/StyleValue.h

@@ -30,11 +30,8 @@ public:

static StyleValue* create(const CSSValue&);

static ScriptValue parse(ScriptState*, const String& property, const String& cssText);

+ virtual String cssString() const = 0;

virtual PassRefPtrWillBeRawPtr<CSSValue> toCSSValue() const = 0;

- virtual String cssString() const

- {

- return toCSSValue()->cssText();

- }

DEFINE_INLINE_VIRTUAL_TRACE() { }