Revert "Update StyleValue.cssString() to use existing methods instead of rolling our…

third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/StyleCalcLength.h"
 
 #include "core/css/CSSCalculationValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/cssom/CalcDictionary.h"
 #include "core/css/cssom/SimpleLength.h"
@@ skipping 106 matching lines @@
     StyleCalcLength* result = StyleCalcLength::create(this, exceptionState);
     for (unsigned i = 0; i < LengthUnit::Count; ++i) {
         LengthUnit lengthUnit = static_cast<LengthUnit>(i);
         if (has(lengthUnit)) {
             result->set(m_values[i] / x, lengthUnit);
         }
     }
     return result;
 }
 
+String StyleCalcLength::cssString() const
+{
+    StringBuilder builder;
+    builder.appendLiteral("calc(");
+    for (unsigned i = 0; i < LengthUnit::Count; ++i) {
+        LengthUnit lengthUnit = static_cast<LengthUnit>(i);
+        if (has(lengthUnit)) {
+            double value = get(lengthUnit);
+            if (value >= 0 && i > 0) {
+                builder.appendLiteral(" + ");
+            } else if (value < 0 && i > 0) {
+                builder.appendLiteral(" - ");
+            } else if (value < 0) {
+                builder.append('-');
+            }
+            builder.appendNumber(std::abs(get(lengthUnit)));
+            builder.append(lengthTypeToString(lengthUnit));
+        }
+    }
+    builder.append(')');
+    return builder.toString();
+}
+
 PassRefPtrWillBeRawPtr<CSSValue> StyleCalcLength::toCSSValue() const
 {
     // Create a CSS Calc Value, then put it into a CSSPrimitiveValue
     RefPtrWillBeRawPtr<CSSCalcExpressionNode> node = nullptr;
     for (unsigned i = 0; i < LengthUnit::Count; ++i) {
         LengthUnit lengthUnit = static_cast<LengthUnit>(i);
         if (!has(lengthUnit))
-            continue;
+            break;
         double value = get(lengthUnit);
-        CSSPrimitiveValue::UnitType primitiveUnit = lengthTypeToPrimitiveType(lengthUnit);
+        CSSPrimitiveValue::UnitType primitiveUnit;
+        if (lengthUnit == LengthUnit::Percent) {
+            primitiveUnit = CSSPrimitiveValue::UnitType::Percentage;
+        } else {
+            // TODO: Don't re-parse the unit here.
+            primitiveUnit = CSSPrimitiveValue::fromName(lengthTypeToString(lengthUnit));
+        }
         if (node) {
             node = CSSCalcValue::createExpressionNode(
                 node,
-                CSSCalcValue::createExpressionNode(CSSPrimitiveValue::create(std::abs(value), primitiveUnit)),
-                value >= 0 ? CalcAdd : CalcSubtract);
+                CSSCalcValue::createExpressionNode(CSSPrimitiveValue::create(value, primitiveUnit)),
+                CalcAdd);
         } else {
             node = CSSCalcValue::createExpressionNode(CSSPrimitiveValue::create(value, primitiveUnit));
         }
     }
     return CSSPrimitiveValue::create(CSSCalcValue::create(node));
 }
 
 } // namespace blink