Add multi-source/dest VMOV to the integrated ARM assembler.

Add multi-source/dest VMOV to the integrated ARM assembler.

Implements moves between double and i64. It also completes the
implementation of the IR "move" instruction, except for vectors.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=eholk@chromium.org, jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a880ac8fcb772331ae7e27712e4da797c6927caa

[Karl, 2016-01-28 22:27:08]

Description was changed from

==========
Add multi-source/dest VMOV to the integrated ARM assembler.

Implements moves between double and i64. It also completes the
implementation of the IR "move" instruction, except for vectors.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add multi-source/dest VMOV to the integrated ARM assembler.

Implements moves between double and i64. It also completes the
implementation of the IR "move" instruction, except for vectors.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-01-28 22:27:08]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Eric Holk, 2016-01-28 22:57:59]

lgtm

[Jim Stichnoth, 2016-01-29 00:54:39]

lgtm

https://codereview.chromium.org/1642253002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1642253002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2438: constexpr const char *Vmovdrr = "Vmovdrr";
Shouldn't this be lowercase?  (here and below)

https://codereview.chromium.org/1642253002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1642253002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1287: // Combine code of emitIASSingleDestSingleSource,
emitIASCoreVFPMove,
s/Combine/combine/

[John, 2016-01-29 01:32:58]

lgtm

[Karl, 2016-01-29 15:28:08]

Description was changed from

==========
Add multi-source/dest VMOV to the integrated ARM assembler.

Implements moves between double and i64. It also completes the
implementation of the IR "move" instruction, except for vectors.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add multi-source/dest VMOV to the integrated ARM assembler.

Implements moves between double and i64. It also completes the
implementation of the IR "move" instruction, except for vectors.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=eholk@chromium.org, jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-29 15:28:09]

Committed patchset #3 (id:40001) manually as
a880ac8fcb772331ae7e27712e4da797c6927caa (presubmit successful).

[Karl, 2016-01-29 15:28:20]

https://codereview.chromium.org/1642253002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1642253002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2438: constexpr const char *Vmovdrr = "Vmovdrr";
On 2016/01/29 00:54:39, stichnot wrote:
> Shouldn't this be lowercase?  (here and below)

Good catch. Fixing.

https://codereview.chromium.org/1642253002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1642253002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1287: // Combine code of emitIASSingleDestSingleSource,
emitIASCoreVFPMove,
On 2016/01/29 00:54:39, stichnot wrote:
> s/Combine/combine/

Done.