Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/IceInstARM32.cpp

Issue 1642253002: Add multi-source/dest VMOV to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | tests_lit/assembler/arm32/vmov-dbl.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index 64a535c5db2adb41a4447babc8c6a8e8afdbd940..f104803b881dfa99bdfa4f1f68151ff2a128d2e7 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1311,13 +1311,17 @@ void InstARM32Mov::emit(const Cfg *Func) const {
}
void InstARM32Mov::emitIAS(const Cfg *Func) const {
- assert(!(isMultiDest() && isMultiSource()) && "Invalid vmov type.");
+ // TODO(kschimpf) Flatten this to a switch statement of dest type. That is,
+ // combine code of emitIASSingleDestSingleSource, emitIASCoreVFPMove,
+ // emitIASScalarVFPMove, emitDoubleToI64Move, and emitI64ToDoubleMove.
auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
- if (!(isMultiDest() || isMultiSource()))
- // Must be single source/dest.
- emitIASSingleDestSingleSource(Func);
+ assert(!(isMultiDest() && isMultiSource()) && "Invalid vmov type.");
+ if (isMultiDest())
+ Asm->vmovrrd(getDest(), getDestHi(), getSrc(0), getPredicate());
+ else if (isMultiSource())
+ Asm->vmovdrr(getDest(), getSrc(0), getSrc(1), getPredicate());
else
- Asm->setNeedsTextFixup();
+ emitIASSingleDestSingleSource(Func);
if (Asm->needsTextFixup())
emitUsingTextFixup(Func);
}
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | tests_lit/assembler/arm32/vmov-dbl.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698