Issue 1641513003: [DevTools] Split DeviceModeView.js into view, toolbar and wrapper.

Issue 1641513003: [DevTools] Split DeviceModeView.js into view, toolbar and wrapper. (Closed)

Created:
4 years, 11 months ago by dgozman

Modified:
4 years, 10 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-remove-files

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Split DeviceModeView.js into view, toolbar and wrapper. Drive-by: put app banner support behind experiment. BUG=540864 Committed: https://crrev.com/569b7399fcfe9c60b3f278c9b0b621bd383d8f9c Cr-Commit-Position: refs/heads/master@{#372026}

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -1226 lines)			Patch
M	third_party/WebKit/Source/devtools/devtools.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js	View	4 chunks	+0 lines, -15 lines	0 comments	Download
A +	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js	View	5 chunks	+5 lines, -547 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js	View	3 chunks	+1 line, -658 lines	0 comments	Download
A	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js	View	1 chunk	+92 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/module.json	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/main/Main.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/screencast/module.json	View	1 chunk	+2 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1647653003 Patch 1

Dependent Patchsets:

Issue 1641003003 Patch 1

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641513003/1

4 years, 10 months ago (2016-01-28 04:10:30 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2016-01-28 05:50:51 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/569b7399fcfe9c60b3f278c9b0b621bd383d8f9c
Cr-Commit-Position: refs/heads/master@{#372026}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages