third_party/WebKit/Source/devtools/front_end/emulation/module.json - Issue 1641513003: [DevTools] Split DeviceModeView.js into view, toolbar and wrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/module.json

Issue 1641513003: [DevTools] Split DeviceModeView.js into view, toolbar and wrapper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-remove-files

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js ('k') | third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/module.json

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/module.json b/third_party/WebKit/Source/devtools/front_end/emulation/module.json

index 8e958ad36a9511a8426f5c6623511a4ff278a72b..2962b8a2eb8b53da9a11ef01aa763bbb7225f31c 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/module.json

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/module.json

@@ -3,7 +3,7 @@

{

"type": "@WebInspector.ActionDelegate",

"actionId": "emulation.toggle-device-mode",

- "className": "WebInspector.DeviceModeView.ActionDelegate",

+ "className": "WebInspector.DeviceModeWrapper.ActionDelegate",

"condition": "can_dock",

"title": "Toggle device mode",

"iconClass": "phone-toolbar-item",

@@ -59,12 +59,13 @@

{

"type": "@WebInspector.ActionDelegate",

"actionId": "emulation.request-app-banner",

- "className": "WebInspector.DeviceModeView.ActionDelegate",

- "title": "Request app banner"

+ "className": "WebInspector.DeviceModeWrapper.ActionDelegate",

+ "title": "Request app banner\u2026"

{

"type": "context-menu-item",

"location": "deviceModeMenu/tools",

+ "experiment": "appBanner",

"order": 10,

"actionId": "emulation.request-app-banner"

}

@@ -84,7 +85,9 @@

"MediaQueryInspector.js",

"SensorsView.js",

"DeviceModeModel.js",

- "DeviceModeView.js"

+ "DeviceModeToolbar.js",

+ "DeviceModeView.js",

+ "DeviceModeWrapper.js"

"resources": [

"devicesSettingsTab.css",